----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113522/#review42834 -----------------------------------------------------------
Ship it! Looks good, modulo the comments below. modules/ECMInstallIcons.cmake <http://git.reviewboard.kde.org/r/113522/#comment30985> Add a note that any file not in this format, or with unrecognized components, will be ignored? Although, actually, it seems unknown groups will be replaced with "actions". modules/ECMInstallIcons.cmake <http://git.reviewboard.kde.org/r/113522/#comment30984> Reading the cmake code, it looks like it should be "sc" for svgz files. - Alex Merry On Oct. 31, 2013, 5:07 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113522/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2013, 5:07 p.m.) > > > Review request for KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > Improve documentation in ECMInstallIcons.cmake > > > Diffs > ----- > > modules/ECMInstallIcons.cmake 1114805 > > Diff: http://git.reviewboard.kde.org/r/113522/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
