Re: Review Request 111686: KPluginFactory macros port

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/ --- (Updated Aug. 6, 2013, 1:01 a.m.) Status -- This change has been mark

Re: Review Request 111686: KPluginFactory macros port

2013-08-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/#review37173 --- This review has been submitted with commit 301d9ba6afe3ba03989

Re: Review Request 111686: KPluginFactory macros port

2013-08-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/#review37171 --- Ship it! staging/kservice/src/plugin/kexportplugin.h

Re: Review Request 111686: KPluginFactory macros port

2013-08-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/ --- (Updated Aug. 5, 2013, 10:59 p.m.) Review request for KDE Frameworks and D

Re: Review Request 111686: KPluginFactory macros port

2013-08-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/#review37057 --- staging/kservice/src/plugin/kexportplugin.h

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
> On July 25, 2013, 4:33 p.m., David Faure wrote: > > staging/kservice/src/plugin/kpluginloader.cpp, line 235 > > > > > > This relates to my comment in the other review. If what we have is a > > list with always

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/ --- (Updated July 30, 2013, 2:33 a.m.) Review request for KDE Frameworks and D

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
> On July 25, 2013, 4:33 p.m., David Faure wrote: > > staging/kservice/src/plugin/kpluginloader.cpp, line 235 > > > > > > This relates to my comment in the other review. If what we have is a > > list with always

Re: Review Request 111686: KPluginFactory macros port

2013-07-29 Thread Sebastian Kügler
> On July 25, 2013, 4:33 p.m., David Faure wrote: > > staging/kservice/src/plugin/kpluginloader.cpp, line 235 > > > > > > This relates to my comment in the other review. If what we have is a > > list with always

Re: Review Request 111686: KPluginFactory macros port

2013-07-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/#review36497 --- staging/kservice/src/plugin/kpluginfactory.h

Re: Review Request 111686: KPluginFactory macros port

2013-07-25 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/ --- (Updated July 25, 2013, 4:10 p.m.) Review request for KDE Frameworks and D