----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111686/#review37057 -----------------------------------------------------------
staging/kservice/src/plugin/kexportplugin.h <http://git.reviewboard.kde.org/r/111686/#comment27386> Hmm, yeah, what happened to "K_EXPORT_PLUGIN_is_deprecated_port_to_K_PLUGIN_HEADER dummy;" from the first version of the patch? The macro is indeed useless now, so it should be deprecated (while being kept for source compat). staging/kservice/src/plugin/kpluginfactory.h <http://git.reviewboard.kde.org/r/111686/#comment27387> K_EXPORT_PLUGIN should be removed from the docs, then. staging/kservice/src/plugin/kpluginfactory.h <http://git.reviewboard.kde.org/r/111686/#comment27388> same here - David Faure On July 30, 2013, 2:33 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111686/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 2:33 a.m.) > > > Review request for KDE Frameworks and David Faure. > > > Description > ------- > > Make K_EXPORT_PLUGIN work with Qt's new plugin system > > This patch changes the K_EXPORT_MACRO and the class it generates to be > compatible with Qt's new plugin / metadata system. It basically replaces the > old macros around q_plugin_instance with the new ones, using Q_INTERFACES. > There's also a setter for the args, which are used to pass metadata into the > plugin. > > Otherwise, this is the minimal change, to make old plugin factories work atop > the new framework. > > This change is source-compatible, but the right .moc file when this macro is > used from the .cpp file. > > > Diffs > ----- > > staging/kservice/src/plugin/kexportplugin.h cc5d58b > staging/kservice/src/plugin/kpluginfactory.h a5ea21b > > Diff: http://git.reviewboard.kde.org/r/111686/diff/ > > > Testing > ------- > > Loaded plugins using KService, KPluginLoader, QPluginLoader and > Plasma::PluginLoader, all work as expected. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
