Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-24 Thread Alexander Neundorf
> On July 23, 2013, 6:47 p.m., Alexander Neundorf wrote: > > What's the current state of dbusmenuqt ? > > Can it be built against both Qt4 and Qt5 ? > > If so, do they have different version numbers then ? > > I don't like that an old version of FindDBusMenuQt.cmake will find the Qt4 > > version

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-24 Thread Alexander Richardson
> On July 24, 2013, 9:43 a.m., Kevin Ottens wrote: > > Ah, I wasn't sure what you meant. I can easily fix this, or should I add a FindDBusMenuQt5.cmake as Alex Neundorf suggested? - Alexander --- This is an automatically generated e-ma

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-24 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36431 --- cmake/modules/FindDBusMenuQt.cmake

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-23 Thread Alexander Richardson
> On July 23, 2013, 8:47 p.m., Alexander Neundorf wrote: > > What's the current state of dbusmenuqt ? > > Can it be built against both Qt4 and Qt5 ? > > If so, do they have different version numbers then ? > > I don't like that an old version of FindDBusMenuQt.cmake will find the Qt4 > > version

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-23 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36406 --- What's the current state of dbusmenuqt ? Can it be built agains

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-23 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/ --- (Updated July 23, 2013, 1:16 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-23 Thread Alexander Richardson
> On July 23, 2013, 11:45 a.m., Kevin Ottens wrote: > > cmake/modules/FindDBusMenuQt.cmake, line 45 > > > > > > We probably want to bump the required minimum version to 0.9 instead of > > removing that block. Not

Re: Review Request 111649: Prevent linking to Qt4 based DBusMenuQt

2013-07-23 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36353 --- cmake/modules/FindDBusMenuQt.cmake