----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111649/#review36431 -----------------------------------------------------------
cmake/modules/FindDBusMenuQt.cmake <http://git.reviewboard.kde.org/r/111649/#comment26900> Sorry but why this new block instead of... cmake/modules/FindDBusMenuQt.cmake <http://git.reviewboard.kde.org/r/111649/#comment26901> ... reintroducing this one just changing "0.4.0" with "0.9.0" ? cmake/modules/FindDBusMenuQt.cmake <http://git.reviewboard.kde.org/r/111649/#comment26902> Looks like this block could be restored, no need to remove it (I'd rather like the patch to be minimal). - Kevin Ottens On July 23, 2013, 11:16 a.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/111649/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 11:16 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Prevent linking to Qt4 based DBusMenuQt > > This fixes all sorts of weird crashes due to having an executable > linked to both Qt4 and Qt5 > > > Diffs > ----- > > cmake/modules/FindDBusMenuQt.cmake c231aeac0fe118577fbd57e83320f59c6e6cc23d > > Diff: http://git.reviewboard.kde.org/r/111649/diff/ > > > Testing > ------- > > kdelibs no longer links to system dbusmenu-qt > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
