On Tuesday 04 March 2014 18:46:53 John Layt wrote:
> Hi,
>
> Here's my first pass through KGuiAddons, focussing on the public api.
>
> KColorCollection
> - Should probably become a QSharedDataPointer
Maybe. But OTOH it's just a QList, two QStrings and a an enum.
> KWorkdWrap
> - "// KDE5 TODO:
On Tue, March 4, 2014 18:46:53 John Layt wrote:
> KImageCache
> KSharedPixmapCacheMixin
> KLocalImageCacheImplementation
> - Looks OK
> - KImageCache not exported, but KLocalImageCacheImplementation is, some
> CMake magic involved?
No CMake. :)
KImageCache depends on KSharedDataCache from KCore
Hi,
Here's my first pass through KGuiAddons, focussing on the public api.
KColorCollection
- Should probably become a QSharedDataPointer
KWorkdWrap
- "// KDE5 TODO: return a value, not a pointer, and use QSharedDataPointer."
KModifierKeyInfo
- Generally looks OK
- Has lots of "bool isKeyPress
