D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

2017-12-04 Thread Michael Pyne
This revision was automatically updated to reflect the committed changes. Closed by commit R249:6e3b70843566: cmake: Mark UIC-generated .h files to skip AUTOMOC by default. (authored by mpyne). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9118?vs=23312&id=23478#toc REPOSITORY R249 KI

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

2017-12-04 Thread Kevin Funk
kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. This shouldn't create any troubles with earlier CMake versions. Also note that we set the same properties unconditionally in newer Qt5 CMake macros: https://codereview.qt-project.org/#/c/

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

2017-12-03 Thread Michael Pyne
mpyne added a comment. In https://phabricator.kde.org/D9118#174892, @aacid wrote: > Will this cause trouble with older cmake versions? Good question, I haven't tried it. I've verified that `set_property` at least is present in 2.8.12

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

2017-12-03 Thread David Faure
dfaure added a reviewer: kfunk. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D9118 To: mpyne, #frameworks, #build_system, #localization, kfunk Cc: aacid

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

2017-12-03 Thread Albert Astals Cid
aacid added a comment. Will this cause trouble with older cmake versions? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D9118 To: mpyne, #frameworks, #build_system, #localization Cc: aacid

D9118: ki18n cmake macros: Mark UIC-generated .h files to skip AUTOMOC by default

2017-12-02 Thread Michael Pyne
mpyne created this revision. mpyne added reviewers: Frameworks, Build System, Localization. Restricted Application added a project: Frameworks. REVISION SUMMARY CMake in 3.10.0 has started warning that `.h` files which are automatically generated have historically been left out of AUTOMOC, and