kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land.
This shouldn't create any troubles with earlier CMake versions. Also note that we set the same properties unconditionally in newer Qt5 CMake macros: https://codereview.qt-project.org/#/c/207327 INLINE COMMENTS > KF5I18NMacros.cmake:56 > ) > + set_property(SOURCE ${_header} PROPERTY SKIP_AUTOMOC ON) > list(APPEND ${_sources} ${_header}) `set_source_files_properties(${_header} ...)` is probably the more canonical way to do this. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D9118 To: mpyne, #frameworks, #build_system, #localization, kfunk Cc: aacid
