D27654: [kio] Fix running konsole on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R241:07ab04bfe774: Fix running konsole on Wayland (authored by wbauer). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27654?vs=76387&id=76607 REVISION DETAIL https://pha

D27654: [kio] Fix running konsole on Wayland

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Hum. OK. Weird. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27654 To: wbauer, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27654: [kio] Fix running konsole on Wayland

wbauer added a comment. In D27654#617946 , @dfaure wrote: > Wait, you're actually passing the icon of the command being executed now (while the old code would end up using the stuff from konsole.desktop I think) AFAICT passing the ic

D27654: [kio] Fix running konsole on Wayland

dfaure added a comment. Since this is konsole specific, it's fine to use a Qt-specific argument. But IMHO you could also just remove the %i altogether. I never understood the idea of "take the icon from the desktop file, not the one the application would use by default". I mean, with som

D27654: [kio] Fix running konsole on Wayland

wbauer updated this revision to Diff 76387. wbauer added a comment. Use `KShell::quoteArg()` in case the icon name contains spaces or other special chars. No idea if that's possible/allowed, but better be safe than sorry I suppose. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://

D27654: [kio] Fix running konsole on Wayland

wbauer edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27654 To: wbauer, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27654: [kio] Fix running konsole on Wayland

wbauer created this revision. wbauer added a reviewer: dfaure. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision. REVISION SUMMARY %i expands to "--icon someicon", but Qt recognizes this option only on X11/xcb. So kon