wbauer created this revision. wbauer added a reviewer: dfaure. wbauer added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. wbauer requested review of this revision.
REVISION SUMMARY %i expands to "--icon someicon", but Qt recognizes this option only on X11/xcb. So konsole failed to start on Wayland. To fix this problem, pass "-qwindowicon" instead, which is supported on all platforms. See https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Exec_key_of_.desktop_files for details. BUG: 408497 FIXED-IN: 5.68.0 TEST PLAN Create a menu entry in kmenueditor that calls a command line application (say, "top"), with "Run in Terminal" (on the "Advanced" tab) enabled. Try to start it from the application menu. konsole starts successfully on Wayland now too, with or without an icon set. Still works on X11/xcb as well. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27654 AFFECTED FILES src/core/desktopexecparser.cpp To: wbauer, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns
