D26664: Same behavior for scrollbar as the desktop style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:02e57319f791: Same behavior for scrollbar as the desktop style (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73631&

D26664: Same behavior for scrollbar as the desktop style

mart marked 3 inline comments as done. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D26664 To: mart, #plasma, #vdg, ngraham Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73631. mart added a comment. - round things REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73621&id=73631 BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D26664 AFFEC

D26664: Same behavior for scrollbar as the desktop style

davidedmundson added inline comments. INLINE COMMENTS > ScrollBar.qml:90 > +visible: !controlRoot.interactive > +x: controlRoot.orientation == Qt.Vertical > +? (parent.width - width) - (parent.width/2 - width/2) * > handleState Math.round? > ScrollBar.qm

D26664: Same behavior for scrollbar as the desktop style

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yeah that's fine for now. We can adjust plasmoid layouts to better accommodate the line in Plasma 5.19. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/newscrollbar REVISION

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73621. mart added a comment. - only show when *not* a plasmoid REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73545&id=73621 BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kd

D26664: Same behavior for scrollbar as the desktop style

mart added a comment. I would put for now an exception for plasmoids to not have such line, thenin a second moment we think about a proper and more complicated solution to update plasmoids design to have something along the lines of the latter mockup REPOSITORY R242 Plasma Framework (Libra

D26664: Same behavior for scrollbar as the desktop style

mart added a comment. actually, doesn't look that good. F7884183: Screenshot_20200115_16.png this is because the scrollview has some margins and no frame, so now the scrollbar appears not centered. those plasmoids would need to not have any

D26664: Same behavior for scrollbar as the desktop style

mart added a comment. In D26664#594322 , @ngraham wrote: > I don't see the separator lines in plasma applets. Is that intentional? most of them are still qqc1, i can look into adding them there as well REPOSITORY R242 Plasma Framework (

D26664: Same behavior for scrollbar as the desktop style

ngraham added a comment. I don't see the separator lines in plasma applets. Is that intentional? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26664 To: mart, #plasma, #vdg, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, br

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73545. mart added a comment. - add missing property REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73543&id=73545 BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D2666

D26664: Same behavior for scrollbar as the desktop style

mart updated this revision to Diff 73543. mart added a comment. - smoother transition REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26664?vs=73525&id=73543 BRANCH phab/newscrollbar REVISION DETAIL https://phabricator.kde.org/D26664

D26664: Same behavior for scrollbar as the desktop style

mart retitled this revision from "same behavior for scrollbar as the desktop style" to "Same behavior for scrollbar as the desktop style". mart edited the test plan for this revision. mart added a reviewer: ngraham. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricat

D26664: same behavior for scrollbar as the desktop style

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY bigger scrollbar and add a small line separator to look consistent with D26655