davidedmundson added inline comments.

INLINE COMMENTS

> ScrollBar.qml:90
> +            visible: !controlRoot.interactive
> +            x: controlRoot.orientation == Qt.Vertical
> +                ? (parent.width - width) - (parent.width/2 - width/2) * 
> handleState

Math.round?

> ScrollBar.qml:94
> +            
> +            y: controlRoot.orientation == Qt.Horizontal
> +                ? (parent.height - height) - (parent.height/2 - height/2) * 
> handleState

Math.round

> scrollbar.svg:149
>           id="rect3856"
> -         width="1"
> +         width="4.000001"
>           height="10"

We seem to have lost a lot of pixel alignment.

Probably won't make any difference unless you render at 20000x the size, but 
might be worth asking Noah/someone how they do it.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/newscrollbar

REVISION DETAIL
  https://phabricator.kde.org/D26664

To: mart, #plasma, #vdg, ngraham
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

Reply via email to