This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ee88418ec827: Port QRegExp to QRegularExpression (and
some QStringRef optimisation) (authored by ahmadsamir).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26236?vs=72
ahmadsamir updated this revision to Diff 72266.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.
Address comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26236?vs=72213&id=72266
BRANCH
l-qregularexpression (branched from mas
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kshorturifilter.cpp:437
> +// URLs using Qt's QRegularExpression class. This is hard-coded for
> now.
> // TODO: Make configurable at some point...
>
ahmadsamir added a task: T12279: Port frameworks away from QRegExp.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D26236
To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ahmadsamir updated this revision to Diff 72213.
ahmadsamir retitled this revision from "Port QRegExp to QRegularExpression (and
some QStringRef) optimisation" to "Port QRegExp to QRegularExpression (and some
QStringRef optimisation)".
ahmadsamir added a comment.
Fix commit message typo
REPOS
ahmadsamir added inline comments.
INLINE COMMENTS
> kurlcompletion.cpp:503
> // no protocol. (QUrl does this only for absolute paths)
> -if (protocol_regex.indexIn(url_copy) == 0) {
> +if (protocol_regex.match(url_copy).hasMatch()) {
> m_kurl = QUrl(url_copy);
hasMatch() i
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
First pass.
TEST PLAN
make && ctest
REPOSITORY
R241 KIO
BRANCH
l-qregularexpression (branched from m
