dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> kshorturifilter.cpp:437
> + // URLs using Qt's QRegularExpression class. This is hard-coded for
> now.
> // TODO: Make configurable at some point...
> for (const URLHint &hint : qAsConst(m_urlHints)) {
(before I forget: this todo should be removed, `KShortUriFilter::configure()`
does exactly that)
> kshorturifilter.h:101
> URLHint(const QString &r, const QString &p, KUriFilterData::UriTypes
> t = KUriFilterData::NetProtocol)
> - : regexp(QRegExp(r))
> + : hintRe(QRegularExpression(r))
> , prepend(p)
(pre-existing) `hintRe(r)` would be enough
REPOSITORY
R241 KIO
BRANCH
l-qregularexpression (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26236
To: ahmadsamir, #frameworks, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
