This revision was automatically updated to reflect the committed changes.
Closed by commit R308:7b356e9dd1ad: Port QRegExp to QRegularExpression
(authored by ahmadsamir).
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26194?vs=72946&id=72947
REVISION DETAIL
ahmadsamir updated this revision to Diff 72946.
ahmadsamir added a comment.
Rebase
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26194?vs=72116&id=72946
BRANCH
l-qregularexpression (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D2
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R308 KRunner
BRANCH
l-qregularexpression (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26194
To: ahmadsamir, #plasma, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB
ahmadsamir added a comment.
Ping.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D26194
To: ahmadsamir, #plasma, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
ahmadsamir updated this revision to Diff 72116.
ahmadsamir marked an inline comment as done.
ahmadsamir added a comment.
More const
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26194?vs=72113&id=72116
BRANCH
l-qregularexpression (branched from master)
ahmadsamir updated this revision to Diff 72113.
ahmadsamir added a comment.
use const (QRegularExpressionMatch is an object too)
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26194?vs=72112&id=72113
BRANCH
l-qregularexpression (branched from master)
RE
apol added a comment.
LGTM otherwise
INLINE COMMENTS
> runnercontext.cpp:575
> for (const QString& entry : cfgList) {
> -r.indexIn(entry);
> -int count = r.cap(1).toInt();
> -QString id = r.cap(2);
> +QRegularExpressionMatch match = re.match(entry);
> +
ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
One instance of QString::remove(QRegExp... was replaced to use the
replace overload that takes a QLatin
