apol added a comment.

  LGTM otherwise

INLINE COMMENTS

> runnercontext.cpp:575
>      for (const QString& entry : cfgList) {
> -        r.indexIn(entry);
> -        int count = r.cap(1).toInt();
> -        QString id = r.cap(2);
> +        QRegularExpressionMatch match = re.match(entry);
> +        if (!match.hasMatch()) {

const

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D26194

To: ahmadsamir, #plasma, davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Reply via email to