jbbgameich added inline comments.
INLINE COMMENTS
> apol wrote in datasourcemodel.h:43
> Use DisplayRole for this?
I intend to add an actual display role later. Strictly speaking this is the id
used by KPeople and not anything that should be shown to the user ideally.
REPOSITORY
R307 KPeople
apol added inline comments.
INLINE COMMENTS
> datasourcemodel.h:43
> +enum RoleNames {
> +PluginIdRole = Qt::UserRole + 1,
> +};
Use DisplayRole for this?
> personpluginmanager.h:91
> + * Creates a contact with the specified @p properties
> + * in the requested backend
>
jbbgameich added a reviewer: Plasma: Mobile.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D25265
To: jbbgameich, apol, #plasma:_mobile
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
jbbgameich updated this revision to Diff 69608.
jbbgameich added a comment.
Use more future proof roleNames and Enum
REPOSITORY
R307 KPeople
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25265?vs=69603&id=69608
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D2526
jbbgameich added a reviewer: apol.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D25265
To: jbbgameich, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
jbbgameich created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jbbgameich requested review of this revision.
REVISION SUMMARY
- Add overload of PersonPluginManager::addContact that takes a pluginId
- Add a DataSourceModel that can later b
