apol added inline comments.
INLINE COMMENTS
> datasourcemodel.h:43
> + enum RoleNames {
> + PluginIdRole = Qt::UserRole + 1,
> + };
Use DisplayRole for this?
> personpluginmanager.h:91
> + * Creates a contact with the specified @p properties
> + * in the requested backend
> + * @returns if it could be done successfully
include @param
> personpluginmanager.h:96
> + */
> + static bool addContact(const QString &pluginId, const QVariantMap
> &properties);
> };
I wonder if that's the best API.
Would it make sense to have separate setDefaultSource(QString) and
addContact(QVariantMap properties).
The default source could even come from a setting in the system.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D25265
To: jbbgameich, apol, #plasma:_mobile
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
