D24372: Compile without deprecated foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7c0402ed9fd7: Compile without deprecated foreach (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24372?vs=67804&id=67808 REVISION DETAIL htt

D24372: Compile without deprecated foreach

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D24372 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24372 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

ahmadsamir added a comment. I had to fix one conflict when rebasing, and basically D24419 ate the foreach src/core/ksslcertificatemanager.cpp@line 128 (by returning the result of calling contains() on the container, neater :)). REPOSITORY R241 KIO BRA

D24372: Compile without deprecated foreach

ahmadsamir updated this revision to Diff 67804. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24372?vs=67510&id=67804 BRANCH arcpatch-D24372 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24372 AFF

D24372: Compile without deprecated foreach

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in job.cpp:181 > IIUC, subjobs() returns a const QList &, do we still need a local const var? > https://api.kde.org/frameworks/kcoreaddons/html/classKCo

D24372: Compile without deprecated foreach

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in job.cpp:181 > You need a local const var to hold the result of the subjobs() method call. > > (repeats) IIUC, subjobs() returns a const QList &, do we still need a local const var? https://api.kde.org/frameworks/kcoreaddons/htm

D24372: Compile without deprecated foreach

ahmadsamir updated this revision to Diff 67510. ahmadsamir marked 7 inline comments as done. ahmadsamir added a comment. - User more descriptive var names other than list2 - qAsConst isn't needed if the method is const and the container is a member var REPOSITORY R241 KIO CHANGES SINCE L

D24372: Compile without deprecated foreach

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > job.cpp:181 > // kill all subjobs, without triggering their result slot > -Q_FOREACH (KJob *it, subjobs()) { > -it->kill(KJob::Quietly); > +

D24372: Compile without deprecated foreach

ahmadsamir created this revision. ahmadsamir added a reviewer: dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY src/core/* src/urifilters/* src/widgets/* TEST PLAN make && ctest REPOSITORY R241 KIO BRANCH ahmad/foreach-urifil