dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > ahmadsamir wrote in job.cpp:181 > IIUC, subjobs() returns a const QList &, do we still need a local const var? > https://api.kde.org/frameworks/kcoreaddons/html/classKCompositeJob.html#aaec8d9b05c7c4194c5ba121d43f2997e Well spotted. Unusual.... > ahmadsamir wrote in dropjob.cpp:270 > m_urls is declared const in DropJobPrivate: > https://cgit.kde.org/kio.git/tree/src/widgets/dropjob.cpp#n142 Oh, interesting :-) REPOSITORY R241 KIO BRANCH ahmad/foreach-urifilters2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24372 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
