D23766: FakeInput: add support for keyboard key press and release

jgrulich closed this revision. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. No, just rambling. Ship it. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasm

D23766: FakeInput: add support for keyboard key press and release

jgrulich added a comment. In D23766#533644 , @apol wrote: > The patch looks good to me, is there a reason why it wasn't accepted? I'm not sure from the comment whether David requested some changes to be made now or whether this is good fo

D23766: FakeInput: add support for keyboard key press and release

apol added a comment. The patch looks good to me, is there a reason why it wasn't accepted? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

davidedmundson added a comment. +1 INLINE COMMENTS > jgrulich wrote in fakeinput.h:222 > I will need a little bit of help to understand what type of key event should > be used and I don't remember where I got the information it expects codes > defined from linux/input-event-codes.h (I copie

D23766: FakeInput: add support for keyboard key press and release

jgrulich updated this revision to Diff 65600. jgrulich added a comment. Bump framework version Apparently KDE Frameworks 5.62 are already out. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23766?vs=65557&id=65600 BRANCH master REVISION DETAIL h

D23766: FakeInput: add support for keyboard key press and release

jgrulich added a dependent revision: D23769: Add support for keyboard key press and release from fake input protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, m

D23766: FakeInput: add support for keyboard key press and release

jgrulich added inline comments. INLINE COMMENTS > jgrulich wrote in fakeinput.h:222 > I will need a little bit of help to understand what type of key event should > be used and I don't remember where I got the information it expects codes > defined from linux/input-event-codes.h (I copied it fr

D23766: FakeInput: add support for keyboard key press and release

jgrulich added inline comments. INLINE COMMENTS > fakeinput.h:222 > + * Request a keyboard button release. > + * @param linuxButton The button code as defined in > linux/input-event-codes.h > + * I will need a little bit of help to understand what type of key event should be used a

D23766: FakeInput: add support for keyboard key press and release

jgrulich added reviewers: davidedmundson, apol, Plasma, romangg. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

jgrulich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jgrulich requested review of this revision. REVISION SUMMARY Adds support for keyboard button press and release as defined in linux/input-event-codes.h REPOSITORY R127 KWaylan