davidedmundson added a comment.
+1 INLINE COMMENTS > jgrulich wrote in fakeinput.h:222 > I will need a little bit of help to understand what type of key event should > be used and I don't remember where I got the information it expects codes > defined from linux/input-event-codes.h (I copied it from the previous review) > > Anyway, for the remote desktop portal, we will need to support both keysym > and keycodes [1]. > > [1] - > https://github.com/flatpak/xdg-desktop-portal/blob/master/data/org.freedesktop.impl.portal.RemoteDesktop.xml#L226 We had a big discussion on this last kwin sprint. There's value in keycodes, values in keysyms depending on the use case. Especially if the remote sender has a different keymap.. Potentially some things don't even map. The protocol could do with a line that the code is related to the keymap set on the client's seat. (currently kwin only really supports one) ----- The "most technically correct" if for fake input to send a keymap, then us to forward that keymap to clients, then pass that keycode on the relevant fake keyboard. IMHO we can do this for now and iterate a year from now. Potentially using virtual_keyboard_unstable_v1 which is basically fully maps wl_keyboard in reverse. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
