bcooksley removed a subscriber: fsitter.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23344
To: sitter, dfaure
Cc: bcooksley, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns,
fsitter
fsitter added a comment.
You think sending your minions to insult me and then disabling my account
will solve the issue? what will you do next? Disable registration so no one
points out your hypocrisy? Which overlord made the decision to disable my
account and for what?
REPOSITORY
R241 KI
fsitter added a comment.
You think sending your minions to insult me and then disabling my account
will solve the issue? what will you do next? Disable registration so no one
points out your hypocrisy? Which overlord made the decision to disable my
account and for what?
REPOSITORY
R241 KI
dfaure added a comment.
LOL, so even the joke (about you writing buggy code) was buggy, good one ;)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D23344
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:830c56744f2b: assert slave command finality (authored by
sitter).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23344?vs=64826&id=64928
REVISION DETAIL
https://phab
sitter added a comment.
Shoes! I meant shoes! 😿
REPOSITORY
R241 KIO
BRANCH
assert
REVISION DETAIL
https://phabricator.kde.org/D23344
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
You put on shows? On TV? :-)
REPOSITORY
R241 KIO
BRANCH
assert
REVISION DETAIL
https://phabricator.kde.org/D23344
To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, micha
sitter updated this revision to Diff 64826.
sitter added a comment.
some days one has to wonder how I manage to put on shows. fix warning branch
as per David's comments to actually do nothing when the cond was matched
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> slavebase.cpp:67
> +#else
> +#define KIO_STATE_ASSERT(cond, where, what) qCWarning(KIO_CORE) << what
> +#endif
Don't you mean if(!cond) { qCWarning... } ? Ot
sitter updated this revision to Diff 64744.
sitter added a comment.
- wrap in custom assert defines that either assert or qwarn based on a cmake
option
- new cmake option KIO_ASSERT_SLAVE_STATES enables the asserts. the option is
only on by default when run on jenkins
- fix a bunch of typ
sitter added a comment.
Yeah, it's certainly a very aggressive change. I also think we need this to
be outside kdeinit5, otherwise unit tests won't crash since they generally
should fork directly. That being said, as a first step maybe we can have this
enabled on the CI and see if existing u
dfaure added a comment.
I see those warnings often, so I'm a bit worried that this will make
kioslaves quite crashy for KDE developers for a while, including those unable
to fix those issues.
At least we need to fix known issues first, like kio_ftp.
How about we both (and ZaWertun)
sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
this changes existing qwarnings in state verification logic to be assertive
in order to
13 matches
Mail list logo
