sitter added a comment.
Yeah, it's certainly a very aggressive change. I also think we need this to be outside kdeinit5, otherwise unit tests won't crash since they generally should fork directly. That being said, as a first step maybe we can have this enabled on the CI and see if existing unit tests start failing. Additionally here's two "transient" options I'd propose: - only enable the asserts for Debug builds **from git**. that way if stuff crashes a lot, the user/developer can expect a quick turn around on the fix - give an env var or cmake option that can opt out of the assertions but still run in debug mode? (the cmake option seems a bit pointless, if you run a Debug build you should get debuggy behavior IMHO). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23344 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
