sitter updated this revision to Diff 62838.
sitter added a comment.
document behavior and when it was introduced, also enable autouic
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22805?vs=62729&id=62838
BRANCH
master
REVISION DETAIL
http
sitter added a comment.
Indeed, both good points.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22805
To: sitter
Cc: vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n,
sbergeron, bencreasy, michaelh, ngraham, bruns
vkrause added a comment.
+1, same for AUTOUIC probably?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22805
To: sitter
Cc: vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n,
sbergeron, bencreasy, michaelh, ngraham, bruns
kossebau added inline comments.
INLINE COMMENTS
> sitter wrote in KDECMakeSettings.cmake:243
> This is cmakes's own behavior. <3.0 has no autorcc to begin with.
>
> That being said the only reason I put the if there is because ECM itself is
> compatible with 2.8.12, so the if seemed appropriate
sitter added inline comments.
INLINE COMMENTS
> kossebau wrote in KDECMakeSettings.cmake:243
> Not sure if anyone is using cmake < 3.0 these days, but if, this will be a
> surprise box to them, as with some biulds things work (where cmake >= 3.0)
> and with some builds not.
>
> This needs expl
kossebau added a comment.
Just a small principal comment with "supporting-old-versions" hat on.
Cannot give feedback on autorcc itself, never used, so no idea how
useful/reliable it is.
INLINE COMMENTS
> KDECMakeSettings.cmake:243
> + # Since CMake 3.0
> + if(NOT CMAKE_VERSION VERSION_
sitter edited the summary of this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22805
To: sitter
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron,
bencreasy, michaelh, ngraham, bruns
apol added a comment.
+1 I've been using it in several project, it works good. I don't see how this
could be misused.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D22805
To: sitter
Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron,
sitter created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
I couldn't find any pertinent discussion on the topic but some reviews I
stumbled over did
