kossebau added a comment.
Just a small principal comment with "supporting-old-versions" hat on. Cannot give feedback on autorcc itself, never used, so no idea how useful/reliable it is. INLINE COMMENTS > KDECMakeSettings.cmake:243 > + # Since CMake 3.0 > + if(NOT CMAKE_VERSION VERSION_LESS 3.0) > + set(CMAKE_AUTORCC ON) Not sure if anyone is using cmake < 3.0 these days, but if, this will be a surprise box to them, as with some biulds things work (where cmake >= 3.0) and with some builds not. This needs explicit mentioning in the docs, so developers know what they have to prepare for, also a mention since which ECM version one can rely on this behaviour. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns
