D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure added a comment. In D22144#520773 , @meven wrote: > This "magic" precisely is what I would have wished to find, it seemed to me something other ioslaves might want, to have contextual log or error message at least. > The pid of the cal

D22144: Add kio recentlyused:/ to access KActivityStats data

kossebau added inline comments. INLINE COMMENTS > meven wrote in CMakeLists.txt:68 > See D23556 Thanks for the quick fixes :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: kossebau, broulik, dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, vmarinescu, fprice, LeGast00n, MrPepe, fbamp

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:68 > Please add a min version, as the code seems to rely on new API only added > recently: > > find_package(KF5ActivitiesStats 5.62.0 QUIET) See D23556

D22144: Add kio recentlyused:/ to access KActivityStats data

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:68 > > +find_package(KF5ActivitiesStats QUIET) > +set_package_properties(KF5ActivitiesStats PROPERTIES Please add a min version, as the code seems to rely on new API only added recently: find_package(KF5ActivitiesStats 5.62.0

D22144: Add kio recentlyused:/ to access KActivityStats data

This revision was automatically updated to reflect the committed changes. Closed by commit R320:ae44042e541c: Add kio recentlyused:/ to access KActivityStats data (authored by meven). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64845&id=64879 R

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham added a comment. I think this can go in now. It's been reviewed by a bunch of the big cheeses. :) Very nice work! REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: broulik,

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64845. meven added a comment. Fix path example REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64736&id=64845 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. In D22144#520684 , @dfaure wrote: > Yep. Either query argument, or KIO metaData(). Both require explicit action from the application, there's no magic currently to know which app is making the request. We could add that, b

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure added a comment. Yep. Either query argument, or KIO metaData(). Both require explicit action from the application, there's no magic currently to know which app is making the request. We could add that, but there are so many way to identify an application that I'm not sure it would wor

D22144: Add kio recentlyused:/ to access KActivityStats data

broulik added a comment. > . The question is how to know inside the KIO slave which application requested its services. If all else fails we could pass a query parameter `recentdocuments://?application=...` since this is mainly meant for the file dialog I presume, there could be some ma

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Filtering can be done as far as the KAStats is concerned. The question is how to know inside the KIO slave which application requested its services. REPOSITORY R320 KIO Extras BRANCH arcpa

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure accepted this revision. dfaure added a comment. No idea about kactivitystats, that's a question for Ivan. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. @dfaure A missing piece for this kio slave is to be able to filter to the current app, meaning the app using the slave. I am not sure there is a way to achieve this yet, please correct me if I am wrong, I've looked around but I could have missed something. REPOSITORY

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 7 inline comments as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in recentlyused.cpp:91 > I'm confused. Which code from ForwardingSlaveBase is this class benefiting > from? > With internalRewriteUrl returning false all SlaveBase reimplementations in > that cla

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, a

D22144: Add kio recentlyused:/ to access KActivityStats data

meven edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampalou

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64736. meven added a comment. Inherit from SlaveBase instead of ForwardingSlaveBase, rename url parameter to path parameter REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64504&id=64736 BRANCH arcpatch-D22

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure added inline comments. INLINE COMMENTS > recentlyused.cpp:186 > +{ > +qCDebug(KIO_RECENTLYUSED_LOG) << "udsEntryFromResource" << " " << > resource; > + You don't need spaces between items, when using q[C]Debug > meven wrote in recentlyused.h:57 > It is path currently due to limitati

D22144: Add kio recentlyused:/ to access KActivityStats data

meven planned changes to this revision. meven added a comment. inherit from SlaveBase instead of ForwardingSlaveBase REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-d

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64504. meven added a comment. Use set*(Term) REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64454&id=64504 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES CM

D22144: Add kio recentlyused:/ to access KActivityStats data

meven planned changes to this revision. meven added a comment. inherit from SlaveBase instead of ForwardingSlaveBase REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-d

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:91 > I started my work upon the recentdocument ioslave that used it and > ForwardingSlaveBase documentation states "It has been designed to support > only local filesystem like ioslaves.. If the resulting ioslave sh

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:109 > We don't have yet set function for Activity, Type, Agent, and Url only add. > Which means we would need to use query.addActivity(QStringList() << ":any")) > sometimes for instance, that is not ideal since it make

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added inline comments. INLINE COMMENTS > ivan wrote in recentlyused.cpp:109 > Also, there are `set*` and `add*` member functions which can be used for > non-chained changes. We don't have yet set function for Activity, Type, Agent, and Url only add. Which means we would need to use query.

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan added inline comments. INLINE COMMENTS > meven wrote in recentlyused.cpp:109 > Tried implementing this in D23372 but > @ivan was not found of it because of induced complexity it entails to work > properly. Also, there are `set*` and `add*` member funct

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, a

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64454. meven added a comment. Fix ISDATE description REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64406&id=64454 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FI

D22144: Add kio recentlyused:/ to access KActivityStats data

dhaumann added inline comments. INLINE COMMENTS > recentlyused.h:46 > + * yesterday respectively. > + * ISODATE must be of the form -MM-DD ( is year, NN month, DD day > of month) > + * If a secondary date is passed, the filtering occurs on the date range > starting NN should be M

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 5 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64406. meven added a comment. Fix date parameter passing REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64403&id=64406 BRANCH arcpatch-D22144_1 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTE

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:29 > You should also set LIBRARY_OUTPUT_DIRECTORY, see > https://community.kde.org/Guidelines_and_HOWTOs/Making_apps_run_uninstalled This will be the first ioslave in kio-extras using it... Some of the ioslave even us

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64403. meven marked 15 inline comments as done. meven added a comment. Fix documentation, CMakeLists.txt, a couple of code fix REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=64347&id=64403 BRANCH arcpatch-D

D22144: Add kio recentlyused:/ to access KActivityStats data

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. You asked for it :-) INLINE COMMENTS > CMakeLists.txt:3 > + > +find_package(KF5 ${KF5_MIN_VERSION} REQUIRED COMPONENTS > +KIO this was already done by the parent CMakeLists.t

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham added a comment. In D22144#514633 , @ivan wrote: > Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? Could you change your status to Accepted or Resigned?? REPOSITORY R320 KIO Extras

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 64347. meven added a comment. Add date and date range filtering after D22775 REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=63829&id=64347 BRANCH arcpatch-D22144 REVIS

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. I'v added @dfaure as reviewer. David feel free to not review this if you think somebody else would be better suited. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: elvisangelacci

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a reviewer: dfaure. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham, dfaure Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, f

D22144: Add kio recentlyused:/ to access KActivityStats data

meven added a comment. In D22144#514633 , @ivan wrote: > Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? Definitely. Do you have an idea who ? BTW, I have one change planned for this wait

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan added a comment. Looks OK to me, I guess some of our resident KIO experts should review it. What do you think? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, a

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham added a comment. @ivan? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, fever

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 63829. meven added a comment. run uncrustify-kf5 REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=62464&id=63829 BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 AFFECTED FILES

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraham Cc: elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, mic

D22144: Add kio recentlyused:/ to access KActivityStats data

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in recentlyused.cpp:140-144 > Could this just be replaced with `query = query | > Agent(agentValue.split(QLatin1Char(',')));`? > > Obviously, the downside is always creating a list (usually with a

D22144: Add kio recentlyused:/ to access KActivityStats data

meven updated this revision to Diff 62464. meven added a comment. Use QStringLiteral only check for commas in string once to check for multiple values parameters, typo REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22144?vs=62417&id=62464 BRANCH arcp

D22144: Add kio recentlyused:/ to access KActivityStats data

ivan requested changes to this revision. ivan added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentlyused.cpp:140-144 > +if (agentValue.contains(QLatin1Char(','))) { > +query = query | Agent(agentValue.split(QLatin1Char(','))); > +

D22144: Add kio recentlyused:/ to access KActivityStats data

ngraham retitled this revision from "Add kio recentlyused:/ to access KactivitytStats data" to "Add kio recentlyused:/ to access KActivityStats data". REPOSITORY R320 KIO Extras BRANCH arcpatch-D22144 REVISION DETAIL https://phabricator.kde.org/D22144 To: meven, ivan, #frameworks, ngraha