meven added inline comments.

INLINE COMMENTS

> ivan wrote in recentlyused.cpp:109
> Also, there are `set*` and `add*` member functions which can be used for 
> non-chained changes.

We don't have yet set function for Activity, Type, Agent, and Url only add.
Which means we would need to use query.addActivity(QStringList() << ":any")) 
sometimes for instance, that is not ideal since it makes the user class use 
internal details such as ":any".
I would be in favor to add setActivity(Terms::Activity) in KactivitiesStats 
same for Type, Agent and Url, to get arount that and maybe also 
addActivity(Terms::Activity) as well for consistency.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22144

To: meven, ivan, #frameworks, ngraham, dfaure
Cc: dhaumann, elvisangelaccio, kde-frameworks-devel, kfm-devel, aprcela, 
vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov

Reply via email to