D21459: Always save view settings when switching from one view mode to another

This revision was automatically updated to reflect the committed changes. Closed by commit R241:69754bfed154: Always save view settings when switching from one view mode to another (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=59058&

D21459: Always save view settings when switching from one view mode to another

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

ngraham added a comment. Your reasoning makes sense. Shipit! :) REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a comment. Any feedback @ngraham ? REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a comment. In D21459#473674 , @ngraham wrote: > If you're going to rename the functions because these actions no longer really toggle anything, I think we need to keep a verb in there. Suggest something like `_k_slotShowDetailsView`

D21459: Always save view settings when switching from one view mode to another

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. If you're going to rename the functions because these actions no longer really toggle anything, I think we need to keep a verb in there. Suggest something like `_k_slotShowDetailsView` or

D21459: Always save view settings when switching from one view mode to another

meven added a comment. In D21459#473429 , @ngraham wrote: > Could you rebase this on current master? It doesn't apply for me right now. Thanks, I forgot to do it ;) Should be fixed now. REPOSITORY R241 KIO REVISION DETAIL https://pha

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 59058. meven added a comment. Rebasing on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58854&id=59058 BRANCH arcpatch-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 AFFECTED FILES src/fil

D21459: Always save view settings when switching from one view mode to another

ngraham added a comment. Could you rebase this on current master? It doesn't apply for me right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a comment. With D21315 landing, great time to have a look at this review ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

ngraham added inline comments. INLINE COMMENTS > meven wrote in kdiroperator.cpp:2691 > Perhaps we could use a more sensible default value for ColumnView. > > What would you say about 32px ? That sounds like a good default size. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.

D21459: Always save view settings when switching from one view mode to another

meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58854. meven added a comment. Rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58816&id=58854 BRANCH new-D21459 REVISION DETAIL https://phabricator.kde.org/D21459 AFFECTED FILES src/filewidgets/kdirop

D21459: Always save view settings when switching from one view mode to another

meven added inline comments. INLINE COMMENTS > kdiroperator.cpp:2691 > +// Simple view decoration left, aka compact view > +return {QStringLiteral("listViewIconSize"), 0}; > +} Perhaps we could use a more sensible default value for ColumnView. What would you say

D21459: Always save view settings when switching from one view mode to another

meven added a comment. In D21459#471238 , @ngraham wrote: > Nice! What do you think about moving the `if (configGroup && itemView) {` into the new function and calling it something more conditional, like `writeIconZoomSettingsIfNeeded`? Also it

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58816. meven added a comment. Add a zoomSettingsForViewForView to group viewKind to zoom setting name and default value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58811&id=58816 BRANCH icon-save2 REVISION DE

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58811. meven added a comment. Rename writeIconZoomSettings to writeIconZoomSettingsIfNeeded, some code improvements REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58780&id=58811 BRANCH icon-save2 REVISION DETAIL

D21459: Always save view settings when switching from one view mode to another

ngraham added a comment. Nice! What do you think about moving the `if (configGroup && itemView) {` into the new function and calling it something more conditional, like `writeIconZoomSettingsIfNeeded`? Also it seems like there could be some code shared in a new function so that `KDirOperator

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58780. meven added a comment. Removing parent commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58779&id=58780 BRANCH icon-save2 REVISION DETAIL https://phabricator.kde.org/D21459 AFFECTED FILES src/file

D21459: Always save view settings when switching from one view mode to another

meven updated this revision to Diff 58779. meven added a comment. Make the expanded detail view and the regular one share the same zoom setting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21459?vs=58778&id=58779 BRANCH icon-save2 REVISION DETAIL https:

D21459: Always save view settings when switching from one view mode to another

meven added a dependency: D21315: Dolphin-style view modes in the file dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven added a task: T8552: Polish Open/Save dialogs. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D21459 To: meven, #frameworks, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21459: Always save view settings when switching from one view mode to another

meven created this revision. meven added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY - Add zoom setings for each view kind - Save and restore zoom when view is cha