meven added a comment.

  In D21459#473674 <https://phabricator.kde.org/D21459#473674>, @ngraham wrote:
  
  > If you're going to rename the functions because these actions no longer 
really toggle anything, I think we need to keep a verb in there. Suggest 
something like `_k_slotShowDetailsView` or `_k_slotSwitchToDetailsView`
  
  
  I was renaming those just to be consistent with the already existing similar 
functions _k_slotDetailedView()     _k_slotSimpleView()     _k_slotTreeView() 
and    _k_slotDetailedTreeView.
  I don't have a strong opinion about adding a verb or keeping as it is now.
  Given the added information, I will follow recommendation.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D21459

REVISION DETAIL
  https://phabricator.kde.org/D21459

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to