D19107: Write valid UTF8 characters without escaping.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R237:2cdcd4f30666: Write valid UTF8 characters without escaping. (authored by vandenoever). REPOSITORY R237 KConfig CHAN

D19107: Write valid UTF8 characters without escaping.

thiago added a comment. It looks good to me. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

vandenoever added a comment. So it's accepted? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

thiago added a comment. Much better, thanks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > thiago wrote in kconfigini.cpp:683 > This function does operate properly to find valid syntax UTF-8 sequences, but > it is neither catching overlong sequences nor UTF-8 content above U+10 > (UTF-8 can encode 0x11000 in 4 bytes). > > See

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52096. vandenoever added a comment. Clean up test by using QTest data. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=52091&id=52096 BRANCH utf8 REVISION DETAIL https://phabricator.kde.org/D19107 AFF

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52091. vandenoever added a comment. Remove duplicate if statement. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=52090&id=52091 BRANCH utf8 REVISION DETAIL https://phabricator.kde.org/D19107 AFFECTE

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52090. vandenoever added a comment. Added tests and code fixes to deal with overlong sequences and content above U+10. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=52015&id=52090 BRANCH utf8 RE

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > thiago wrote in kconfigini.cpp:683 > This function does operate properly to find valid syntax UTF-8 sequences, but > it is neither catching overlong sequences nor UTF-8 content above U+10 > (UTF-8 can encode 0x11000 in 4 bytes). > > See

D19107: Write valid UTF8 characters without escaping.

thiago added inline comments. INLINE COMMENTS > vandenoever wrote in kconfigini.cpp:683 > A check for U+10 > value is needed. > Overlong sequences are caught on line 696 (count < 4). That's not what an overlong sequence is. You can produce 2-, 3- and 4-byte overlong sequences. See the examp

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > thiago wrote in kconfigini.cpp:683 > This function does operate properly to find valid syntax UTF-8 sequences, but > it is neither catching overlong sequences nor UTF-8 content above U+10 > (UTF-8 can encode 0x11000 in 4 bytes). > > See

D19107: Write valid UTF8 characters without escaping.

thiago added inline comments. INLINE COMMENTS > kconfigini.cpp:683 > +// When an additional byte leads to an invalid character, return > false. > +bool addByte(unsigned char b) { > +if (count == 0) { This function does operate properly to find valid syntax UTF-8 sequ

D19107: Write valid UTF8 characters without escaping.

vandenoever updated this revision to Diff 52015. vandenoever added a comment. - Remove VALUE define. - Spelling fix. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19107?vs=51933&id=52015 BRANCH utf8 REVISION DETAIL https://phabricator.kde.org/D1910

D19107: Write valid UTF8 characters without escaping.

vandenoever added inline comments. INLINE COMMENTS > dfaure wrote in kconfigtest.cpp:1774 > What's the purpose of this very short-lived define, compared to just inlining > this into the next line? Right, copy-paste leftover. I'll fix it. REPOSITORY R237 KConfig REVISION DETAIL https://pha

D19107: Write valid UTF8 characters without escaping.

vandenoever added a reviewer: thiago. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks, thiago Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

dfaure added a comment. No objection from me, but I'm no utf-8 expert. Thiago's input would be very valuable... INLINE COMMENTS > kconfigtest.cpp:1774 > +#endif > +#define VALUE > "v1=Téléchargements\nv2=$¢ह€𐍈\nv3=\\xc2\\xe0\\xa4\\xf0\\x90\\x8d" > +QCOMPARE(fileBytes, QByteArrayLite

D19107: Write valid UTF8 characters without escaping.

ngraham added a reviewer: Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol, #frameworks Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

rapiteanu added a comment. The commit fixes (as expected) the config write issue observed in 403557. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D19107 To: vandenoever, dfaure, arichardson, apol Cc: rapiteanu, kde-frameworks-devel, michaelh, ngraham, bruns

D19107: Write valid UTF8 characters without escaping.

vandenoever created this revision. vandenoever added reviewers: dfaure, arichardson, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vandenoever requested review of this revision. REVISION SUMMARY commit 6a18528