D17851: Add Android notification backend

vkrause added inline comments. INLINE COMMENTS > vkrause wrote in notifybyandroid.cpp:125 > Possible, I'll investigate. Addressed in D18526 . REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17851 To: vkrause, apol Cc: broulik

D17851: Add Android notification backend

vkrause added inline comments. INLINE COMMENTS > broulik wrote in notifybyandroid.cpp:79 > Can there be multiple instances of this `NotifyByAndroid`? KNotificationManager prevents that IIUC. > broulik wrote in notifybyandroid.cpp:125 > Does this need a `FreeLocalRef` call? Possible, I'll inves

D17851: Add Android notification backend

broulik added a comment. Pretty cool! INLINE COMMENTS > notifybyandroid.cpp:79 > +{ > +s_instance = this; > +#if __ANDROID_API__ >= 23 Can there be multiple instances of this `NotifyByAndroid`? > notifybyandroid.cpp:125 > +pixmap.save(&buffer, "PNG"); > +auto jIconData = env->Ne

D17851: Add Android notification backend

vkrause added a comment. In D17851#386243 , @nicolasfella wrote: > Please note that all apps uploaded to the Play Store need to have a target API level >= 26 (Oreo). This means (among other things) that notifications need to have a channel (see

D17851: Add Android notification backend

nicolasfella added a comment. Please note that all apps uploaded to the Play Store need to have a target API level >= 26 (Oreo). This means (among other things) that notifications need to have a channel (see https://developer.android.com/training/notify-user/channels). The current code will

D17851: Add Android notification backend

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a54c7b17045a: Add Android notification backend (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17851?vs=48339&id=48609 REVISION DETAIL

D17851: Add Android notification backend

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. These changes only will apply to Android, so let's get this in. The status quo is broken there anyway. As for the application, it could be in a separate repository too, no need to bloat th

D17851: Add Android notification backend

vkrause added a comment. In D17851#383718 , @nicolasfella wrote: > By using AndroidX (formerly known as the support library) we could enable it for Android version older than 23 (which is about 29% of all active devices). That would require add

D17851: Add Android notification backend

apol added a comment. This looks really cool! I'd say let's get this in and we can iterate from here if needed. Maybe it would be useful to have builds of a test application? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17851 To: vkrause Cc: apol, nic

D17851: Add Android notification backend

nicolasfella added a comment. By using AndroidX (formerly known as the support library) we could enable it for Android version older than 23 (which is about 29% of all active devices). That would require adding the appropriate jar to the build. REPOSITORY R289 KNotifications REVISION DETA

D17851: Add Android notification backend

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY There are probably still many features that aren't properly mapped to Android, but at least the basics work: - te