broulik added a comment.
Pretty cool!
INLINE COMMENTS
> notifybyandroid.cpp:79
> +{
> + s_instance = this;
> +#if __ANDROID_API__ >= 23
Can there be multiple instances of this `NotifyByAndroid`?
> notifybyandroid.cpp:125
> + pixmap.save(&buffer, "PNG");
> + auto jIconData = env->NewByteArray(iconData.length());
> + env->SetByteArrayRegion(jIconData, 0, iconData.length(),
> reinterpret_cast<const jbyte*>(iconData.constData()));
Does this need a `FreeLocalRef` call?
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D17851
To: vkrause, apol
Cc: broulik, apol, nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns
