D15047: Export the StorageDevices object.

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. You still have not addressed the raised issues. This gets annoying ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, br

D15047: Export the StorageDevices object.

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippic

D15047: Export the StorageDevices object.

smithjd updated this revision to Diff 43357. smithjd added a comment. - Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15047?vs=43353&id=43357 BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL https://phabricator.kde.org/

D15047: Export the StorageDevices object.

ngraham added reviewers: Baloo, bruns, poboiko. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik, #baloo, bruns, poboiko Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D15047: Export the StorageDevices object.

smithjd updated this revision to Diff 43353. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D15047: Export the StorageDevices object.

smithjd added a comment. In D15047#314741 , @bruns wrote: > In D15047#314485 , @smithjd wrote: > > > In D15047#314477 , @bruns wrote: > > > > > There i

D15047: Export the StorageDevices object.

bruns added a comment. In D15047#314485 , @smithjd wrote: > In D15047#314477 , @bruns wrote: > > > There is no need for this, just create a new StorageDevices where you need it. > > Creating a sec

D15047: Export the StorageDevices object.

bruns added inline comments. INLINE COMMENTS > smithjd wrote in fileindexerconfig.cpp:322 > According to > https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops this > particular example will detach with or without the const intermediate. Citing from above: > To sum this up,

D15047: Export the StorageDevices object.

smithjd marked an inline comment as done. smithjd added a comment. In D15047#314477 , @bruns wrote: > There is no need for this, just create a new StorageDevices where you need it. > Creating a second StorageDevices instance in a process is qu

D15047: Export the StorageDevices object.

bruns added a comment. There is no need for this, just create a new StorageDevices where you need it. Creating a second StorageDevices instance in a process is quite cheap. INLINE COMMENTS > fileindexerconfig.cpp:322 > // been explicitly added in the include list > -const auto allM

D15047: Export the StorageDevices object.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abra

D15047: Export the StorageDevices object.

smithjd added a reviewer: broulik. smithjd added a comment. This was included in https://phabricator.kde.org/D11529 and is now broken out. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michae

D15047: Export the StorageDevices object.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL https://phabricator.kde