smithjd marked an inline comment as done. smithjd added a comment.
In D15047#314477 <https://phabricator.kde.org/D15047#314477>, @bruns wrote: > There is no need for this, just create a new StorageDevices where you need it. > Creating a second StorageDevices instance in a process is quite cheap. Creating a separate object cluttered the console with duplicated debug output and raised a threading error. INLINE COMMENTS > bruns wrote in fileindexerconfig.cpp:322 > This is bad, you remove the const from the QList<> > Read up about Qt and detaching ... According to https://www.dvratil.cz/2015/06/qt-containers-and-c11-range-based-loops this particular example will detach with or without the const intermediate. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams
