D14236: Add some improvements to kate-syntax-highlighter for use in scripting

xciml added a comment. Thank you! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14236 To: xciml, #framework_syntax_highlighting, vkrause, cullmann Cc: cullmann, pino, kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, bmortimer, michae

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

cullmann added a comment. Thanks for the enhancements! I just did hide the bestCandidate function as static helper, no need to expose them at all in the header: Git commit 60affa47908782d2bda94af2e49fa3f1c4608f4e

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:08b871457b79: Add some improvements to kate-syntax-highlighter for use in scripting (authored by xciml, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then lets land this, if Volker is ok already ;=) I will push it, I want to just hide the bestCandidate from the header afterwards. REPOSITORY R216 Syntax Highlighting REVISION

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

xciml updated this revision to Diff 40467. xciml marked an inline comment as done. xciml added a comment. In D14236#315639 , @cullmann wrote: > I am not sure about the default argument for title, why not just have there QString() and in the code

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

vkrause added a comment. In D14236#315639 , @cullmann wrote: > Otherwise: Volker, what do you think? Fine with me, the features/changes make sense IMHO. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

cullmann added a comment. I am not sure about the default argument for title, why not just have there QString() and in the code instead of isNull() an isEmpty => use file name fallback. The definitionForMimeType must perhaps use the priority, too, if there are duplicates, like the definiti

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

xciml updated this revision to Diff 39700. xciml added a comment. Hi! Good idea, what about this? REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14236?vs=38102&id=39700 REVISION DETAIL https://phabricator.kde.org/D14236 AFFECTED FILES src/

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

dhaumann added a reviewer: vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14236 To: xciml, #framework_syntax_highlighting, vkrause Cc: kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, michaelh, genethomas, kevinapavew, ngraham, b

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

pino added inline comments. INLINE COMMENTS > htmlhighlighter.h:42-43 > void highlightFile(const QString &fileName); > +void highlightFile(const QString &fileName, const QString &title); > +void highlightFile(QFile &file, const QString &title); > Instead of both the variants, what

D14236: Add some improvements to kate-syntax-highlighter for use in scripting

xciml created this revision. xciml added a reviewer: Framework: Syntax Highlighting. xciml added a project: Framework: Syntax Highlighting. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. xciml requested review of this revision. REV