cullmann added a comment.
Thanks for the enhancements! I just did hide the bestCandidate function as static helper, no need to expose them at all in the header: Git commit 60affa47908782d2bda94af2e49fa3f1c4608f4e <https://phabricator.kde.org/R216:60affa47908782d2bda94af2e49fa3f1c4608f4e> by Christoph Cullmann. Committed on 30/08/2018 at 07:51. Pushed by cullmann into branch 'master'. hide bestCandidate, can be static function inside file M +12 -12 src/lib/repository.cpp M +0 -2 src/lib/repository.h https://commits.kde.org/syntax-highlighting/60affa47908782d2bda94af2e49fa3f1c4608f4e REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14236 To: xciml, #framework_syntax_highlighting, vkrause, cullmann Cc: cullmann, pino, kde-frameworks-devel, kwrite-devel, #framework_syntax_highlighting, bmortimer, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, vkrause, sars, dhaumann
