kossebau added a comment.
Seems this was pushed only after the tagging of 5.48 was done on Saturday
night, so too late for that release.
If this should be still part of 5.48, get in contact with dfaure so he could
consider moving the tag/release pointer to include this commit, or please
up
This revision was automatically updated to reflect the committed changes.
dschmidt marked an inline comment as done.
Closed by commit R240:2c2bb8f4766f: Improve ECMAddAppIconMacro. (authored by
dschmidt).
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.o
cgiboudeaux added a comment.
The 5.48 release is close. Don't forget to push these changes.
REPOSITORY
R240 Extra CMake Modules
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry, cgiboudeaux
Cc: cgiboudeaux,
cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.
Thanks !
REPOSITORY
R240 Extra CMake Modules
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerr
apol added a comment.
+1
Looks good to me, even tested. :)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
cgiboudeaux added a comment.
from a buildsystem pov, the change looks fine. Maybe someone has comments to
add.
@apol ?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-framewor
dschmidt marked 8 inline comments as done.
dschmidt added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in ECMAddAppIcon.cmake:161
> 36? It's not mentioned in the doc.
Good catch, I forgot to update this part after I fixed the resolutions in a
different place.. The resolutions I copied f
dschmidt updated this revision to Diff 36891.
dschmidt added a comment.
Fix since version in FindIcoTool too
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36890&id=36891
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabr
dschmidt updated this revision to Diff 36890.
dschmidt added a comment.
Fix comment
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36889&id=36890
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/D13698
AF
dschmidt updated this revision to Diff 36889.
dschmidt added a comment.
Fix "Since version" and wrong resolutions in a few places
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36719&id=36889
BRANCH
app-icon-modernization
REVISION D
cgiboudeaux added inline comments.
INLINE COMMENTS
> FindIcoTool.cmake:25
> +#
> +# Since 5.49.
> +
The next release will be 5.48
> ECMAddAppIcon.cmake:11-12
> +# ICONS [ [...]]
> +# [SIDEBAR_ICONS [ [...]] # Since 5.49
> +# [OUTFILE_BASEN
dschmidt marked 2 inline comments as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
dschmidt updated this revision to Diff 36719.
dschmidt added a comment.
Remove debug spam ...
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36718&id=36719
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/
dschmidt updated this revision to Diff 36718.
dschmidt added a comment.
Commit fixes to the actual ECMAddAppIconMacro
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36715&id=36718
BRANCH
app-icon-modernization
REVISION DETAIL
http
dschmidt edited the summary of this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
dschmidt updated this revision to Diff 36715.
dschmidt added a comment.
Squashed everything into one commit, sigh.
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36713&id=36715
BRANCH
app-icon-modernization
REVISION DETAIL
https:/
dschmidt updated this revision to Diff 36713.
dschmidt added a comment.
Removed crap commit
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36712&id=36713
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/D13698
AFFECTED FILES
docs/find-module
dschmidt updated this revision to Diff 36712.
dschmidt added a comment.
Fix macOS tests
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36710&id=36712
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/D13698
AFFECTED FILES
docs/find-module/Fin
dschmidt added a comment.
Added license, documentation and Alex Merry as copyright holder as the find
module for png2ico was written by him.
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsys
dschmidt marked 4 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
dschmidt updated this revision to Diff 36710.
dschmidt added a comment.
- Add copyright, license and documentation to FindIcoTool
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36707&id=36710
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/D13
dschmidt updated this revision to Diff 36707.
dschmidt added a comment.
Tests stub and parameter rename
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36564&id=36707
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/D13698
AFFECTED FILES
test
cgiboudeaux added inline comments.
INLINE COMMENTS
> vpinon wrote in FindIcoTool.cmake:1
> Hello,
> FindIcoTool.cmake is largely copied from FindPng2Ico.cmake, I'm even not sure
> I can really claim the copyright.
> In any case, I would choose the same license as all other ECM files (among
> wh
vpinon added inline comments.
INLINE COMMENTS
> dschmidt wrote in FindIcoTool.cmake:1
> @vpinon Can you let me know what you want here?
Hello,
FindIcoTool.cmake is largely copied from FindPng2Ico.cmake, I'm even not sure I
can really claim the copyright.
In any case, I would choose the same lic
dschmidt marked an inline comment as done.
dschmidt added inline comments.
INLINE COMMENTS
> cgiboudeaux wrote in FindIcoTool.cmake:1
> - Missing doc
> - Missing license
@vpinon Can you let me know what you want here?
> cgiboudeaux wrote in ECMAddAppIcon.cmake:105-106
> ECMAddAppIcon has an uni
cgiboudeaux added inline comments.
INLINE COMMENTS
> FindIcoTool.cmake:1
> +# Copyright 2017 Vincent Pinon
> +
- Missing doc
- Missing license
> ECMAddAppIcon.cmake:70
>
> +
>
> #=
extra line that shouldn't be the
dschmidt edited the test plan for this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
dschmidt updated this revision to Diff 36564.
dschmidt added a comment.
Update documentation again
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36563&id=36564
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde
dschmidt updated this revision to Diff 36563.
dschmidt added a comment.
Updated documentation
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13698?vs=36562&id=36563
BRANCH
app-icon-modernization
REVISION DETAIL
https://phabricator.kde.org/
dschmidt edited the summary of this revision.
dschmidt added reviewers: vpinon, apol, alexmerry.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,
dschmidt edited the summary of this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
dschmidt created this revision.
dschmidt added a reviewer: vonreth.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
dschmidt requested review of this revision.
REVISION SUMMARY
- Add support for SID
32 matches
Mail list logo
