cgiboudeaux added inline comments.
INLINE COMMENTS
> FindIcoTool.cmake:1
> +# Copyright 2017 Vincent Pinon <vpi...@kde.org>
> +
- Missing doc
- Missing license
> ECMAddAppIcon.cmake:70
>
> +
>
> #=============================================================================
extra line that shouldn't be there
> ECMAddAppIcon.cmake:105-106
> set(options)
> - set(oneValueArgs)
> - set(multiValueArgs ICONS)
> + set(oneValueArgs OUTFILE_BASE)
> + set(multiValueArgs ICONS SIDEBAR_ICONS)
> cmake_parse_arguments(ARG "${options}" "${oneValueArgs}"
> "${multiValueArgs}" ${ARGN})
ECMAddAppIcon has an unit test in tests/ECMAddAppIconTest/
Please check if you can test the new parameters.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D13698
To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
