This revision was automatically updated to reflect the committed changes.
Closed by commit R236:0a70dc9bb0f2: [KCharSelect] Port generate-datafile.py to
Python 3 (authored by cfeck).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D13641?vs=36490&id=36790#toc
REPOSITORY
R236 KWidgetsAddo
lbeltrame accepted this revision.
lbeltrame added a comment.
This revision is now accepted and ready to land.
I did an accept to undo my earlier "Changes required" because Phab messed up
the lines I commented on, and because I realized I wasn't commenting on your
specific changes. Sorry about
lbeltrame requested changes to this revision.
lbeltrame added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcharselect-generate-datafile.py:41
Perhaps the diff view is wrong.. but the `return size` here (at this level of
nesting) wouldn't make the downstrea
cfeck requested review of this revision.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13641
To: cfeck, #frameworks, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
cfeck updated this revision to Diff 36490.
cfeck added a comment.
This revision is now accepted and ready to land.
len() of UTF-8 encoded bytearray is different than len(str).
Account for the difference when accumulating sizes.
Unicode Names are always ASCII, so here len(bytearray) == le
cfeck planned changes to this revision.
cfeck added a comment.
Needs more changes :/
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13641
To: cfeck, #frameworks, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
lbeltrame accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D13641
To: cfeck, #frameworks, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
cfeck created this revision.
cfeck added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
cfeck requested review of this revision.
REVISION SUMMARY
- Add missing parentheses for print()
- Writing string
