lbeltrame requested changes to this revision. lbeltrame added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kcharselect-generate-datafile.py:41 Perhaps the diff view is wrong.. but the `return size` here (at this level of nesting) wouldn't make the downstream code de facto unreachable in this function? > kcharselect-generate-datafile.py:118 Same here. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13641 To: cfeck, #frameworks, lbeltrame Cc: kde-frameworks-devel, michaelh, ngraham, bruns
