This revision was automatically updated to reflect the committed changes.
Closed by commit R244:53f44072c70a: Fix compiler warning under Clang (authored
by kfunk).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12112?vs=31888&id=31914
REVISION DETAIL
ht
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
☕
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12112
To: kfunk, apol
Cc: apol, #frameworks, michaelh, ngraham, bruns
kfunk updated this revision to Diff 31888.
kfunk added a comment.
Address concerns. I knew why I put this up for review. /me grabs another
coffee...
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12112?vs=31878&id=31888
BRANCH
master
REVISION DETAI
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.
Otherwise looks good.
INLINE COMMENTS
> kshareddatacache_p.h:170
> +__attribute__((always_inline, gnu_inline
> +#if defined(Q_CC_GNU) && !defined(Q_CC_INTEL) && !defined(Q_CC_CLAN
kfunk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kfunk requested review of this revision.
REVISION SUMMARY
Issue:
In file included from .../kcoreaddons/src/lib/caching/kshareddatacache.cpp:25:
.../kcoreadd
