apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed.
Otherwise looks good. INLINE COMMENTS > kshareddatacache_p.h:170 > + __attribute__((always_inline, gnu_inline > +#if defined(Q_CC_GNU) && !defined(Q_CC_INTEL) && !defined(Q_CC_CLANG) > + , artificial No need to check twice for Q_CC_GNU REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D12112 To: kfunk, apol Cc: apol, #frameworks, michaelh, ngraham, bruns
