Re: Review Request 115387: rename dbus interface file for kinit

2014-01-30 Thread Stefano Avallone
to give the ship it. - Stefano Avallone On Jan. 29, 2014, 4:27 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115353/#review48476 --- On Jan. 28, 2014, 2:28 p.m., Stefano Avallone wrote: > > --- > This is

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
, so please check that this patch does not produce unwanted side-effects. Thanks, Stefano Avallone ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
not produce unwanted side-effects. Thanks, Stefano Avallone ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115353: Rename dbus interface files for solid

2014-01-28 Thread Stefano Avallone
://git.reviewboard.kde.org/r/115353/diff/ Testing --- Builds and installs fine. I am not an expert of dbus interface files and cmake, so please check that this patch does not produce unwanted side-effects. Thanks, Stefano Avallone ___ Kde-frameworks-devel

Re: kate (frameworks) build failure

2014-01-22 Thread Stefano Avallone
Hi, On Wednesday 22 January 2014 19:12:17 Christoph Cullmann wrote: > Hi, > > in ktexteditor/document.h is: > > > // our main baseclass of the KTextEditor::Document > #include > > perhaps you need to cleanup your local include dirs ;) you're right, I knew it was my fault. Pardon me for not h

kate (frameworks) build failure

2014-01-22 Thread Stefano Avallone
Hello, looks like building kate (frameworks branch) fails: In file included from /home/stefano/pkgbuild/kf5/kate- git/src/kate/kwrite/kwrite.h:25:0, from /home/stefano/pkgbuild/kf5/kate- git/src/kate/kwrite/main.cpp:21: /opt/kf5/include/KF5/KTextEditor/ktexteditor/document.h:122:

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

2014-01-20 Thread Stefano Avallone
fine Thanks, Stefano Avallone ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

2014-01-20 Thread Stefano Avallone
his is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115140/#review47802 --- On Jan. 20, 2014, 3:25 p.m., Stefano Avallone wrote: > > --- > This i

Re: Review Request 115140: kde-workspace doesn't explicitly need attica anymore

2014-01-20 Thread Stefano Avallone
dated) - CMakeLists.txt f1bd8a7 Diff: https://git.reviewboard.kde.org/r/115140/diff/ Testing --- Builds fine Thanks, Stefano Avallone ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frame

Review Request 115140: Adapt to new attica name

2014-01-20 Thread Stefano Avallone
-workspace Description --- Update CMakeLists.txt to match the new name of LibAttica Diffs - CMakeLists.txt f1bd8a7 Diff: https://git.reviewboard.kde.org/r/115140/diff/ Testing --- Builds fine Thanks, Stefano Avallone ___ Kde