> On Jan. 28, 2014, 2:25 p.m., Jonathan Riddell wrote: > > What does this have that https://git.reviewboard.kde.org/r/114927/ doesn't? > >
Pardon me. I somehow missed that review request. - Stefano ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115353/#review48476 ----------------------------------------------------------- On Jan. 28, 2014, 2:28 p.m., Stefano Avallone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115353/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2014, 2:28 p.m.) > > > Review request for KDE Frameworks. > > > Repository: solid > > > Description > ------- > > The dbus interface files installed by solid conflict with those installed by > kdelib4. To allow co-installability of kde4 and kf5, rename the former by > using the same approach adopted for kglobalaccess, kjobviewer, etc. > > If this patch seems reasonable, I will submit the companion patch for > kde-workspace. > > > Diffs > ----- > > src/solid/CMakeLists.txt 84c254e > > Diff: https://git.reviewboard.kde.org/r/115353/diff/ > > > Testing > ------- > > Builds and installs fine. I am not an expert of dbus interface files and > cmake, so please check that this patch does not produce unwanted side-effects. > > > Thanks, > > Stefano Avallone > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
