Re: Review Request 120096: replace static arrays with dynamic size with QVector

2017-02-04 Thread Patrick Spendrin
/ Testing --- windows Thanks, Patrick Spendrin

Re: Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Patrick Spendrin
marked as submitted. Review request for KDE Frameworks and Plasma. Changes --- Submitted with commit 54736e262f80b62686c11d542d5d239233243d1f by Patrick Spendrin to branch master. Repository: plasma-framework Description --- my Qt won't cast char* to QString, so explicitl

Review Request 126417: don't rely on char* to QString implicit conversion

2015-12-18 Thread Patrick Spendrin
-framework Description --- my Qt won't cast char* to QString, so explicitly use QStringLiteral here. Diffs - src/plasmaquick/appletquickitem.cpp 614b793fa724e7be0fb2dd8151374303fcc6ec18 Diff: https://git.reviewboard.kde.org/r/126417/diff/ Testing --- Windows. Thanks, Pa

Review Request 126416: MetaFunction doesn't need to be exported

2015-12-18 Thread Patrick Spendrin
--- Header only functions don't need to be exported, as there is no code in the dynamic library available. Diffs - src/core/metafunction.h 71ce3470ca627f4d2b90b5cdd94cfe87a41c9a8f Diff: https://git.reviewboard.kde.org/r/126416/diff/ Testing --- Windows. Thanks, Patrick Spe

Re: Review Request 126327: sonnet: Do not use QStringLiteral with multi strings

2015-12-18 Thread Patrick Spendrin
sting --- Windows. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126330: use generate_export_header

2015-12-16 Thread Patrick Spendrin
. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

2015-12-16 Thread Patrick Spendrin
marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 71dd42f902c8fa09f6eca5e762c2e46a45161767 by Patrick R. Spendrin on behalf of Patrick Spendrin to branch master. Repository: kwidgetsaddons Description --- Strings that are

Re: Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

2015-12-16 Thread Patrick Spendrin
src/kdbusservice.cpp d17bfd2b971d462cc9ddea37624f1e71c7d0f16e Diff: https://git.reviewboard.kde.org/r/126326/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kd

Re: Review Request 126330: use generate_export_header

2015-12-16 Thread Patrick Spendrin
6c2aae34556136b70c0f092fc921745d6e313eda src/calendarevents/calendarevents_export.h a4c6f87e62c02a4ed34d0ebff00e0a729357952f Diff: https://git.reviewboard.kde.org/r/126330/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing

Re: Review Request 126330: use Qt defines for portability

2015-12-16 Thread Patrick Spendrin
vents/CMakeLists.txt 6c2aae34556136b70c0f092fc921745d6e313eda src/calendarevents/calendarevents_export.h a4c6f87e62c02a4ed34d0ebff00e0a729357952f Diff: https://git.reviewboard.kde.org/r/126330/diff/ Testing --- Windows. Thanks, Patrick Spe

Re: Review Request 126339: remove kdewin dependency

2015-12-16 Thread Patrick Spendrin
marked as submitted. Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit 8c26b8cda03327ec5d49203cd4144d3e35debaf9 by Patrick Spendrin to branch master. Repository: khtml Description --- This removes the direct kdewin dependency

Re: Review Request 126339: remove kdewin dependency

2015-12-14 Thread Patrick Spendrin
t.cpp 1ad3bbb9b6d6a022799d5ef85f426fc9f911d45b Diff: https://git.reviewboard.kde.org/r/126339/diff/ Testing --- Windows, Linux compiles. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinf

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

2015-12-14 Thread Patrick Spendrin
dgets/kpropertiesdialog.cpp 0ff506273a10dba238fefc5c552c71434681285e Diff: https://git.reviewboard.kde.org/r/126329/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kd

Review Request 126339: remove kdewin dependency

2015-12-14 Thread Patrick Spendrin
/khtml_pagecache.cpp 8e1841f6b0e816dfd8faa76f2191b269c4716011 src/khtml_part.cpp adbcd800a526e9f8fd92a553e62ee64791872938 src/kmultipart/kmultipart.cpp 1ad3bbb9b6d6a022799d5ef85f426fc9f911d45b Diff: https://git.reviewboard.kde.org/r/126339/diff/ Testing --- Windows, Linux compiles. Thanks, Patrick

Re: Review Request 126325: kwidgetsaddons: Do not use QStringLiteral with multi strings

2015-12-13 Thread Patrick Spendrin
3b413 tests/kmessageboxtest.cpp 73e5f7acf297eb9fb39bbcaf03f79ff9e17e29ac Diff: https://git.reviewboard.kde.org/r/126325/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 126329: kio: Do not use QStringLiteral with multi strings

2015-12-13 Thread Patrick Spendrin
l.cpp b409c1b1617f97f3cdbc79a2c76110a5f9449398 src/ioslaves/help/kio_help.cpp cb27a77b22fe378a126d985621985265edb93767 src/widgets/kpropertiesdialog.cpp 0ff506273a10dba238fefc5c552c71434681285e Diff: https://git.reviewboard.kde.org/r/126329/diff/ Testing --- Windows. Thanks, Patrick Spe

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

2015-12-13 Thread Patrick Spendrin
------ On Dez. 13, 2015, 9:57 nachm., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126328/ > ---

Re: Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

2015-12-13 Thread Patrick Spendrin
ntime/kwalletd/kwalletd.cpp 5f99f161a0911732c4d46ab36f2e4f3d3f3e3c4b Diff: https://git.reviewboard.kde.org/r/126328/diff/ Testing --- Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/ma

Review Request 126330: use Qt defines for portability

2015-12-12 Thread Patrick Spendrin
. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126329: kio: Do not use QStringLiteral with multi strings

2015-12-12 Thread Patrick Spendrin
laves/help/kio_help.cpp cb27a77b22fe378a126d985621985265edb93767 src/widgets/kpropertiesdialog.cpp 0ff506273a10dba238fefc5c552c71434681285e Diff: https://git.reviewboard.kde.org/r/126329/diff/ Testing --- Windows. Thanks, Patrick Spendrin __

Review Request 126328: kwallet: Do not use QStringLiteral with multi strings

2015-12-12 Thread Patrick Spendrin
t the same, joining the strings does work too though. Diffs - src/runtime/kwalletd/kwalletd.cpp 5f99f161a0911732c4d46ab36f2e4f3d3f3e3c4b Diff: https://git.reviewboard.kde.org/r/126328/diff/ Testing --- Thanks, Patrick Spendrin __

Review Request 126326: kdbusaddons: Do not use QStringLiteral with multi strings

2015-12-12 Thread Patrick Spendrin
ayout the same, joining the strings would work too though. Diffs - src/kdbusservice.cpp d17bfd2b971d462cc9ddea37624f1e71c7d0f16e Diff: https://git.reviewboard.kde.org/r/126326/diff/ Testing --- Windows. Thanks, Patrick Spendrin __

Review Request 126327: sonnet: Do not use QStringLiteral with multi strings

2015-12-12 Thread Patrick Spendrin
t.cpp a1ccb28aab35e2491b1512241a05767429ce84d9 Diff: https://git.reviewboard.kde.org/r/126327/diff/ Testing --- Windows. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126325: Do not use QStringLiteral with multi strings

2015-12-12 Thread Patrick Spendrin
sting --- Windows. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125647: Fix KArchiveTest::testTarCopyTo on NTFS

2015-10-15 Thread Patrick Spendrin
speed matters a lot. I am not sure if ntfs under Linux (with ntfs-3g) has the same problems, but for windows I want to see it correctly. - Patrick Spendrin On Okt. 15, 2015, 3:08 nachm., Eric Lemanissier wrote: > > --- > This is an

Re: X11 on Windows

2015-10-12 Thread Patrick Spendrin
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am 12.10.2015 um 10:01 schrieb Jaroslaw Staniek: > On 12 October 2015 at 08:33, Martin Graesslin > wrote: >> Hi frameworks and windows devs, >> >> from the release announcement of the latest frameworks release I >> learned that there were multiple ch

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2015-08-27 Thread Patrick Spendrin
erent solution for that (it depends on the way the executables are run in QProcess), but I would need to look into the KDE4 code which starts kdeinit4.exe. kdeinit4 *is* a console app. - Patrick Spendrin On Aug. 27, 2015, 7:31 vorm., Kevin Funk

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

2015-02-12 Thread Patrick Spendrin
/118155/diff/ Testing --- mingw Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122177: some minor fixes for windows

2015-01-21 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/122177/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122177: some minor fixes for windows

2015-01-21 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/122177/diff/ Testing --- windows msvc 2013 Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122177: some minor fixes for windows

2015-01-20 Thread Patrick Spendrin
Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120324: Simplify CMake code for DTD generation (WIN32/non-WIN32)

2014-09-25 Thread Patrick Spendrin
> On Sept. 22, 2014, 10:53 nachm., Luigi Toscano wrote: > > Re-reading the code and the comments, the core of the problem is described > > later, in another part which should be touched by the patch. The comment > > says: > > > > # WARNING: this has severe limitations on the windows platform s

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
and David Faure. Repository: karchive Description --- on windows static arrays can only be initialized with a const Diffs - src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 Diff: https://git.reviewboard.kde.org/r/120096/diff/ Testing --- windows Thanks, Patrick

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
ard.kde.org/r/120096/#review66046 --- On Sept. 9, 2014, 9:14 vorm., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To reply, visit:

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-09 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/120096/diff/ Testing --- windows Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Patrick Spendrin
Description --- on windows static arrays can only be initialized with a const Diffs - src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 Diff: https://git.reviewboard.kde.org/r/120096/diff/ Testing --- windows Thanks, Patrick Spendrin

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-23 Thread Patrick Spendrin
g/r/118852/#comment42406> Did you try out whether removing the Flags calls did change something? - Patrick Spendrin On June 21, 2014, 12:20 a.m., Nicolás Alvarez wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
://git.reviewboard.kde.org/r/118153/diff/ Testing --- mingw Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118115: adapt to ecm_add_test

2014-05-15 Thread Patrick Spendrin
, please tell me. Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin
: https://git.reviewboard.kde.org/r/118147/diff/ Testing --- windows Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118155: adapt to ecm_add_tests so that tests can be found

2014-05-15 Thread Patrick Spendrin
-framework Description --- adapt to ecm_add_tests so that tests can be found Diffs - autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 Diff: https://git.reviewboard.kde.org/r/118155/diff/ Testing --- mingw Thanks, Patrick Spendrin

Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Patrick Spendrin
-framework Description --- remove unneeded file which collides with kf5plasma exports Diffs - autotests/CMakeLists.txt dcee37f0771753d3e381e9d77f351cff16531e93 Diff: https://git.reviewboard.kde.org/r/118153/diff/ Testing --- mingw Thanks, Patrick Spendrin

Re: Review Request 118119: remove unneeded header

2014-05-15 Thread Patrick Spendrin
--- mingw windows Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118147: fix running ECMKDEModules test

2014-05-15 Thread Patrick Spendrin
kdewin. Repository: extra-cmake-modules Description --- fix running ECMKDEModules test Diffs - tests/ExecuteKDEModules/CMakeLists.txt e149ec7af0f85cf3b4a0e3501fc23befad6403b9 Diff: https://git.reviewboard.kde.org/r/118147/diff/ Testing --- windows Thanks, Patrick

Review Request 118119: remove unneeded header

2014-05-13 Thread Patrick Spendrin
-framework Description --- remove unneeded header Diffs - src/plasma/theme.cpp aed5b98609d8502f05ca8b8404d92efd4eedf8d4 Diff: https://git.reviewboard.kde.org/r/118119/diff/ Testing --- mingw windows Thanks, Patrick Spendrin

Review Request 118115: adapt to ecm_add_test

2014-05-13 Thread Patrick Spendrin
) 43 - indenttest (Failed) 44 - commands_test (Failed) 45 - scripting_test (SEGFAULT) 46 - bug313759 (Failed) 51 - keys (Failed) If some of these now fail on Linux too, please tell me. Thanks, Patrick Spendrin ___ Kde

Re: Review Request 118085: adapt to ecm_add_tests

2014-05-12 Thread Patrick Spendrin
Diff: https://git.reviewboard.kde.org/r/118085/diff/ Testing --- windows gcc, not all tests pass, and I can't say if that is due to my change (it shouldn't be) Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-framew

Review Request 118085: adapt to ecm_add_tests

2014-05-11 Thread Patrick Spendrin
tests pass, and I can't say if that is due to my change (it shouldn't be) Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [extra-cmake-modules] modules: Revert "use the NAME_PREFIX only for the test, not for the executable"

2014-05-10 Thread Patrick Spendrin
Am 10.05.2014 12:28, schrieb Alex Merry: > Git commit 7213137a75e832976c25168ae640d26369c771a7 by Alex Merry. > Committed on 10/05/2014 at 10:26. > Pushed by alexmerry into branch 'master'. > > Revert "use the NAME_PREFIX only for the test, not for the executable" > > This reverts commits > b90

Re: Review Request 118026: Fix KF5_ADD_KDEINIT_EXECUTABLE on Windows

2014-05-07 Thread Patrick Spendrin
eason required us to use the current setup. If it becomes a problem, we have to modify it anyway. - Patrick Spendrin On May 6, 2014, 8:29 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply,

KF5 on Windows IRC meeting tonight

2014-05-06 Thread Patrick Spendrin
Hi everybody, for those interested, there will be a kf5 meeting on #kde-windows on freenode tonight at 20:00 UTC (22:00 CEST). Some topics can be gathered on the wiki page: http://techbase.kde.org/Projects/KDE_on_Windows/kf5/meetingnotes-2014-05-06 sorry for the short notice, regards, Patrick _

Re: Review Request 117962: forward declare specialisation

2014-05-06 Thread Patrick Spendrin
after instantiation. Diffs - src/lib/util/kuser.h 7b14ab2b2b31fcc3c624bba6068df6ad80b779fe Diff: https://git.reviewboard.kde.org/r/117962/diff/ Testing --- mingw gcc, *nix and msvc still required Thanks, Patrick Spendrin ___ Kde

Re: Review Request 117961: remove several warnings on mingw

2014-05-06 Thread Patrick Spendrin
, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117965: use the correct global variables

2014-05-04 Thread Patrick Spendrin
import & static libraries and plugins end up in the lib subdir of the build directory. Diffs - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick Spen

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
lib subdir of the build directory. Diffs (updated) - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick Spendrin ___

Re: Review Request 117967: use different syntax to run the target in question instead of an executable in the path

2014-05-03 Thread Patrick Spendrin
/diff/ Testing --- windows Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > <https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170> > > > > Now the comment doesn't match the code - which is correct?

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
p in the lib subdir of the build directory. Diffs - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick Spendrin ___

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
> On May 3, 2014, 10:10 a.m., Alex Merry wrote: > > kde-modules/KDECMakeSettings.cmake, lines 170-176 > > <https://git.reviewboard.kde.org/r/117965/diff/1/?file=271235#file271235line170> > > > > Now the comment doesn't match the code - which is correct?

Re: Review Request 117965: use the correct global variables

2014-05-03 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117965/#review57180 ------- On May 2, 2014, 10:53 p.m., Patrick Spendrin wrote: > > ---

Re: Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Patrick Spendrin
it.reviewboard.kde.org/r/117961/#review57173 ------- On May 2, 2014, 9:16 p.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail. To rep

Review Request 117967: use different syntax to run the target in question instead of an executable in the path

2014-05-02 Thread Patrick Spendrin
k for targets of the same name though, which is the wanted behaviour here. Diffs - modules/ECMAddTests.cmake 9052d8863fb9447b751387199e649efaedc69a3d Diff: https://git.reviewboard.kde.org/r/117967/diff/ Testing --- windows Thanks, Patrick Spe

Review Request 117965: use the correct global variables

2014-05-02 Thread Patrick Spendrin
kdewin. Repository: extra-cmake-modules Description --- use the correct global variables Diffs - kde-modules/KDECMakeSettings.cmake c206ff82ca76e7fda6538f407b83eea6ecab1242 Diff: https://git.reviewboard.kde.org/r/117965/diff/ Testing --- windows Thanks, Patrick

Review Request 117962: forward declare specialisation

2014-05-02 Thread Patrick Spendrin
7b14ab2b2b31fcc3c624bba6068df6ad80b779fe Diff: https://git.reviewboard.kde.org/r/117962/diff/ Testing --- mingw gcc, *nix and msvc still required Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 117961: remove several warnings on mingw

2014-05-02 Thread Patrick Spendrin
src/lib/util/kuser_win.cpp 2018a129f3ef9911df0c3f071d1617cac3026168 Diff: https://git.reviewboard.kde.org/r/117961/diff/ Testing --- mingw only, needs testing on *nix and on msvc Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-24 Thread Patrick Spendrin
gt; I know. The problem is QStandardPaths with > QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I > think %APPDATA%. KF5 based KDE software won't work otherwise since it can't > find the data. I think the better way of fixing this is patching Qt,

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-01-22 Thread Patrick Spendrin
> On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote: > > Until now we had no problems with the data installed to bin/../share and > > this setup would make it impossible to have multiple independent kde > > setups on one system. > > Alexander Richardson wrote: > I know. The problem is

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-10-21 Thread Patrick Spendrin
://en.wikipedia.org/wiki/CPUID#EAX.3D1:_Processor_Info_and_Feature_Bits . Diffs - tier1/solid/src/solid/processor.h ce4f0e1 tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-05-22 Thread Patrick Spendrin
) - tier1/solid/src/solid/processor.h ce4f0e1 tier1/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-05-22 Thread Patrick Spendrin
ly, visit: http://git.reviewboard.kde.org/r/108845/#review32127 --- On Feb. 8, 2013, 1:09 a.m., Patrick Spendrin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 108845: add support for SSSE3 and SSE4.2 in cpufeatures and for msvc

2013-02-07 Thread Patrick Spendrin
/solid/src/solid/backends/shared/cpufeatures.cpp baa1af2 tier1/solid/src/solid/processor.h ce4f0e1 Diff: http://git.reviewboard.kde.org/r/108845/diff/ Testing --- Windows Thanks, Patrick Spendrin ___ Kde-frameworks-devel mailing list Kde

Re: Separating everything ?

2013-02-07 Thread Patrick Spendrin
Am 07.02.2013 23:32, schrieb Frank Reininghaus: ... Since I am reading this thread by chance, I might as well reply. One of the reasons of splitting kdelibs into separate repositories is to simplify the usage of single modules. >From the perspective of a full *KDE* desktop, there is no problem in

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-08 Thread Patrick Spendrin
Am 08.08.2012 22:52, schrieb Alexander Neundorf: > On Tuesday 07 August 2012, Patrick Spendrin wrote: > >> Am 07.08.2012 22:42, schrieb Alexander Neundorf: > > ... > >> > Setting CMAKE_REQUIRED_INCLUDES and CMAKE_REQUIRED_LIBRARIES within the > >>

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-07 Thread Patrick Spendrin
Am 07.08.2012 22:42, schrieb Alexander Neundorf: > On Tuesday 07 August 2012, Patrick Spendrin wrote: > >> Am 06.08.2012 21:35, schrieb Alexander Neundorf: > >> >> I added a KDEWinConfig.cmake as a first step > >> > > >> > Can you post a link

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-07 Thread Patrick Spendrin
Am 06.08.2012 21:35, schrieb Alexander Neundorf: > >> I added a KDEWinConfig.cmake as a first step > > Can you post a link to it here ? https://projects.kde.org/projects/kdesupport/kdewin/repository/revisions/70fec467fecfde722b1da55a1f805e852c20bf47 and the following patch. regards, Patrick >

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-06 Thread Patrick Spendrin
emove > > layers and ensure that Qt and cmake have everything we need to compile our > > standalone libs on top of them. > > > > Please evaluate what needs the "kdewin" (library, right?), and whether > > that code can't be ported to "

Re: Review Request: Don't lose the original CMAKE_MODULE_PATH

2012-08-05 Thread Patrick Spendrin
, 9:11 p.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105863/ > --- > > (Updated Aug. 4, 2012, 9:11 p.m.) > > >

Re: KDE_EXPORT is needed

2012-07-05 Thread Patrick Spendrin
Am 05.07.2012 12:55, schrieb David Faure: > On Thursday 05 July 2012 12:32:34 Patrick Spendrin wrote: >> Am 05.07.2012 09:17, schrieb David Faure: >>> On Wednesday 04 July 2012 14:26:09 Patrick Spendrin wrote: >>>> One issue I have found was that KDE_EXPO

Re: Windows patches

2012-07-05 Thread Patrick Spendrin
Am 04.07.2012 16:20, schrieb Stephen Kelly: > Patrick Spendrin wrote: > >> Hi everybody, >> >> I am now half way through building kdelibs frameworks branch on windows. >> >> Some things I want to mention: >> - most unittests are console applications o

Re: KDE_EXPORT is needed

2012-07-05 Thread Patrick Spendrin
Am 05.07.2012 09:17, schrieb David Faure: > On Wednesday 04 July 2012 14:26:09 Patrick Spendrin wrote: >> One issue I have found was that KDE_EXPORT and KDE_IMPORT went missing. >> >> KDE_EXPORT and KDE_IMPORT are needed e.g. if you want to export a >> function from

KDE_EXPORT is needed

2012-07-04 Thread Patrick Spendrin
One issue I have found was that KDE_EXPORT and KDE_IMPORT went missing. KDE_EXPORT and KDE_IMPORT are needed e.g. if you want to export a function from a plugin (you never want to import it) meaning that it is needed for K_EXPORT_PLUGIN to work properly. In that special case we could use Q_DECL_EX

Windows patches

2012-07-04 Thread Patrick Spendrin
Hi everybody, I am now half way through building kdelibs frameworks branch on windows. Some things I want to mention: - most unittests are console applications on Windows and so they need to be linked against the stub library qtmain.lib. I committed a patch which does this already for quite a lot

Re: Unnecessary cmake code in solid ?

2012-05-13 Thread Patrick Spendrin
Am 13.05.2012 11:07, schrieb Alexander Neundorf: > Hi, > > in solid/src/CMakeLists.txt there is this code: > > file(MAKE_DIRECTORY > > ${CMAKE_CURRENT_BINARY_DIR}/backends/fakehw > > ${CMAKE_CURRENT_BINARY_DIR}/backends/hal > > ${CMAKE_CURRENT_BINARY_DIR}/backends/udev > > ${CMAKE_CURRENT_BIN

Re: setting EXECUTABLE_OUTPUT_PATH in tier1/ tests ?

2012-05-10 Thread Patrick Spendrin
Am 10.05.2012 23:22, schrieb David Faure: > On Thursday 10 May 2012 12:09:59 Patrick Spendrin wrote: >> Am 10.05.2012 11:52, schrieb David Faure: >>> Even on Windows I like to have everything in one place, but yes, it >>> requires setting PATH. No big deal, th

Re: kdelibs (tier1) splitting package/repository granularity

2012-05-10 Thread Patrick Spendrin
Am 10.05.2012 23:00, schrieb Alexander Neundorf: > The situation with the tier1 libs is very different than with KDE4 > kdelibs: no dependencies between each other, no runtime dependencies. > > Why not put all tier1 libraries into one repository and release them as > one package ? > > Keep t

Re: setting EXECUTABLE_OUTPUT_PATH in tier1/ tests ?

2012-05-10 Thread Patrick Spendrin
Am 10.05.2012 11:52, schrieb David Faure: > On Thursday 10 May 2012 11:15:57 Patrick Spendrin wrote: >> Am 10.05.2012 10:45, schrieb David Faure: >>> On Thursday 10 May 2012 10:36:20 Patrick Spendrin wrote: >>>>> set(EXECUTABLE_OUTPUT_PATH ${CMAKE_CURREN

Re: setting EXECUTABLE_OUTPUT_PATH in tier1/ tests ?

2012-05-10 Thread Patrick Spendrin
Am 10.05.2012 10:45, schrieb David Faure: > On Thursday 10 May 2012 10:36:20 Patrick Spendrin wrote: >>> set(EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR}) >> >> Yes, the EXECUTABLE_OUTPUT_PATH should be set per project into the >> project binary_dir\bin >

Re: setting EXECUTABLE_OUTPUT_PATH in tier1/ tests ?

2012-05-10 Thread Patrick Spendrin
[resending since I am now subscribed ;-)] Am 09.05.2012 22:18, schrieb Alexander Neundorf: > Hi, > > in several autotests/ directories in tier1/ EXECUTABLE_OUTPUT_PATH is > set like this: > > set(EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR}) Yes, the EXECUTABLE_OUTPUT_PATH should be set pe

Re: setting EXECUTABLE_OUTPUT_PATH in tier1/ tests ?

2012-05-10 Thread Patrick Spendrin
Am 09.05.2012 22:18, schrieb Alexander Neundorf: > Hi, > > in several autotests/ directories in tier1/ EXECUTABLE_OUTPUT_PATH is > set like this: > > set(EXECUTABLE_OUTPUT_PATH ${CMAKE_CURRENT_BINARY_DIR}) Yes, the EXECUTABLE_OUTPUT_PATH should be set per project into the project binary_dir\bin