> On Sept. 8, 2014, 11:24 vorm., Milian Wolff wrote: > > src/k7zip.cpp, line 1509 > > <https://git.reviewboard.kde.org/r/120096/diff/1/?file=310286#file310286line1509> > > > > this could be a QByteArray directly, and again resize it, not reserve.
Should I also move the encodedBuffer out of the loop to reduce the number of allocs/deallocs? I am not sure how important this is though... - Patrick ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66046 ----------------------------------------------------------- On Sept. 9, 2014, 9:14 vorm., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120096/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 9:14 vorm.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > ------- > > on windows static arrays can only be initialized with a const > > > Diffs > ----- > > src/k7zip.cpp 2db043520ebff6bf7661e8ac993d107f4bd6a5e7 > > Diff: https://git.reviewboard.kde.org/r/120096/diff/ > > > Testing > ------- > > windows > > > Thanks, > > Patrick Spendrin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
