D18878: Force NT1 protocol when listing smb:// network [work in progress]

mikhailnov abandoned this revision. mikhailnov added a comment. +1, it is nod needed with recent WSD support REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, broulik, ngraham Cc: sitter, ngraham, acrouthamel, kde-framewo

D18878: Force NT1 protocol when listing smb:// network [work in progress]

mikhailnov updated this revision to Diff 51577. mikhailnov retitled this revision from "Force NT1 protocol when listing smb:// network" to "Force NT1 protocol when listing smb:// network [work in progress]". mikhailnov added a comment. Here is a new prototype of the patch. It builds, but the p

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. I've done some tests in a clean virtual environment, and must say that this patch actually does not work, because kioclient5 ls smb:/ does not detect workgroups without setting [global] client max protocol = NT1 in ~/.smb/smb.conf I

D18878: Force NT1 protocol when listing smb:// network

mikhailnov updated this revision to Diff 51443. mikhailnov added a comment. fixed patch REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18878?vs=51302&id=51443 REVISION DETAIL https://phabricator.kde.org/D18878 AFFECTED FILES cmake/FindSamba.cmake

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. Forgot to write that SMB1 is used to list the network, then, when connection is done, protocol version must be chosen again automatically, SMB3 is default in newest samba. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikh

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. In D18878#409822 , @sitter wrote: > https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/ > > I cannot approve this. It is opening potential security issues, overrides sysadmin configs, diverges f

D18878: Force NT1 protocol when listing smb:// network

mikhailnov edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, sitter, broulik Cc: ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales

D18878: Force NT1 protocol when listing smb:// network

mikhailnov updated this revision to Diff 51302. mikhailnov added a comment. smbc_setOptionProtocols() does not edit context. smbc_set_context(nullptr) will not change context, but will only return existing one. P.S. qCDebug(KIO_SMB) does not print anything for some reason now... REPOSIT

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. In D18878#408686 , @acrouthamel wrote: > How do dependencies work here? Does this force SMB1 to be installed and enabled in Dolphin now? I ask because many companies have disabled and removed version 1 due to the sec

D18878: Force NT1 protocol when listing smb:// network

mikhailnov added a comment. Samba developers told that currently other methods of browsong network, than using old SMB1 protocol, are not implemented. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov Cc: kde-frameworks-devel, kfm-devel, alexde

D18878: Force NT1 protocol when listing smb:// network

mikhailnov created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. mikhailnov requested review of this revision. REVISION SUMMARY Samba 4.8 changed default 'client max protocol' from NT1 to SMB3, together with fixes of Badloc