mikhailnov added a comment.
In D18878#408686 <https://phabricator.kde.org/D18878#408686>, @acrouthamel wrote: > How do dependencies work here? Does this force SMB1 to be installed and enabled in Dolphin now? I ask because many companies have disabled and removed version 1 due to the security issues. How can smb1 be installed? libsmbclient.so.0 can work using different versions of SMB protocol depending on it's version (but it's API and ABI are stable). It chooses protocol version by itself. SMB2 and SMB3 currently cannot be discovered via NetBIOS by samba, because only smb1 supports netbios discovery, but samba developers have some plans to send DCERPC over smb2/smb3 connections (I don;t know what is DCERPC, but that's what samba developer told me). Before samba 4.7, NT1 (smb1) the maximum protocol in libsmbclient, if I'm not mistaken; then they made it possible to connect to smb3 servers without manually rising client max protocol, this and/or badlock fixes broke network discovery via smb://, for now, the only way is to manually force NT1 whaen needed, it's what this patch does. See also https://bugzilla.samba.org/show_bug.cgi?id=13782 REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov Cc: acrouthamel, kde-frameworks-devel, kfm-devel, alexde, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov
