Re: Review Request 120467: Native Qt Quick FileDialog

- src/platformtheme/kdeplatformfiledialoghelper.cpp 0a4f89f Diff: https://git.reviewboard.kde.org/r/120467/diff/ Testing --- Dialog visible. Select file: returns name and quits Cancel: closes dialog but doesn't quit! Thanks, Maarten De Meyer _

Re: Review Request 120185: Look for kdesu in the correct location

uteUID=true Now I can launch it as root and when I remove kdesu I got a normal error message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120267/#review68253 --- On Oct. 4, 2014, 12:56 p.m., Maarten De Meyer wrote: > > -

Re: Review Request 120458: Port html, djvu and folder thumbcreators

:iconNameForUrl or only here? Thanks. - Maarten --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120458/#review67885 ----------- On Oct. 4, 2014, 5:31 p.m., Maarten De Meyer wrote: > > --

Re: Review Request 120458: Port html, djvu and folder thumbcreators

://git.reviewboard.kde.org/r/120458/diff/ Testing --- Thumbnails work. djvu and html only tested with a single file each. It would be great if somebody with a big collection of these files could check for regressions. Thanks, Maarten De Meyer ___ Kde

Re: Review Request 120185: Look for kdesu in the correct location

r message. Unit test no longer skips because kdesu is not found. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

Or do you know of a better way that doen't use the name? - Maarten --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120267/#review67874 -----------

Re: Review Request 120267: Don't run kioexec if we are already running it

files don't work (before and after) I'll take a look at that next. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

wboard.kde.org/r/120267/#review67855 --- On Sept. 18, 2014, 4:33 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Review Request 120467: Native Qt Quick FileDialog

doesn't quit! Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120458: Port html, djvu and folder thumbcreators

--- Thumbnails work. djvu and html only tested with a single file each. It would be great if somebody with a big collection of these files could check for regressions. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 120458: Port html, djvu and folder thumbcreators

tested with a single file each. It would be great if somebody with a big collection of these files could check for regressions. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 120408: Port textcreator thumbnailer

- thumbnail/thumbnail.cpp 3a38dc9 thumbnail/textcreator.cpp d3f633c thumbnail/CMakeLists.txt aec8b8e Diff: https://git.reviewboard.kde.org/r/120408/diff/ Testing --- Text thumbnails work. Utf8 files show with the correct encoding. Thanks, Maarten De Meyer

Re: Review Request 120408: Port textcreator thumbnailer

/textcreator.cpp d3f633c thumbnail/CMakeLists.txt aec8b8e Diff: https://git.reviewboard.kde.org/r/120408/diff/ Testing --- Text thumbnails work. Utf8 files show with the correct encoding. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing

Review Request 120408: Port textcreator thumbnailer

3a38dc9 Diff: https://git.reviewboard.kde.org/r/120408/diff/ Testing --- Text thumbnails work. Utf8 files show with the correct encoding. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 120382: Port comicbook thumbnailer to KF5

thumbnail/CMakeLists.txt cd1263a thumbnail/comiccreator.cpp 39df58a Diff: https://git.reviewboard.kde.org/r/120382/diff/ Testing --- Works fine on my small collection (only cbr files) Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailin

Re: Review Request 120382: Port comicbook thumbnailer to KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120382/#review67505 ----------- On Sept. 27, 2014, 10:12 a.m., Maarten De Meyer wrote: > >

Re: Review Request 120382: Port comicbook thumbnailer to KF5

thumbnail/comiccreator.cpp 39df58a Diff: https://git.reviewboard.kde.org/r/120382/diff/ Testing --- Works fine on my small collection (only cbr files) Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://ma

Re: Review Request 120382: Port comicbook thumbnailer to KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120382/#review67504 ----------- On Sept. 27, 2014, 10:12 a.m., Maarten De Meyer wrote: > >

Review Request 120382: Port comicbook thumbnailer to KF5

iff: https://git.reviewboard.kde.org/r/120382/diff/ Testing --- Works fine on my small collection (only cbr files) Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120185: Look for kdesu in the correct location

> On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: > > this approach is probably better than > > https://git.reviewboard.kde.org/r/120040/ > > Maarten De Meyer wrote: > I think we'll need both. We still need to rename the kdesu binary, no? > > Marc

Review Request 120267: Don't run kioexec if we are already running it

Diffs - src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120267/diff/ Testing --- Run kioexec with local file from command line. Remote files don't work (before and after) I'll take a look at that next. Thanks, Maarten De Meyer

Re: Review Request 120185: Look for kdesu in the correct location

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/#review66656 --- On Sept. 13, 2014, 3:59 p.m., Maarten De Meyer wrote: > > --

Re: Review Request 120040: Install kdesu under bin

> On Sept. 2, 2014, 6:54 p.m., Hrvoje Senjan wrote: > > >in kde4 kdesu was installed under bin > > > > it was actually also in libexec. just that KStandardDirs::findExe() looked > > in libexec paths, QStandardPaths doesn't... > > Marco Martin wrote: > right, it seems on both places here, b

Review Request 120185: Look for kdesu in the correct location

s - src/core/config-kiocore.h.cmake 3c2e4a8 src/core/desktopexecparser.cpp 9510697 Diff: https://git.reviewboard.kde.org/r/120185/diff/ Testing --- Created .desktop file with X-KDE-SubstituteUID=true Now I can launch it as root and when I remove kdesu I got a

Re: Review Request 120131: Fix encoding issue in places dialog.

and dolphin. Any other code where kbookmarks is used that I should check for regressions? Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120131: Fix encoding issue in places dialog.

nd why was the cast to ascii and latin1 needed? Diffs - src/kbookmark.cpp 9543120 Diff: https://git.reviewboard.kde.org/r/120131/diff/ Testing --- Tested with placesview from kwrite and dolphin. Any other code where kbookmarks is used that I should check for regressions?

Re: Review Request 120071: QUrl::fromUserInput in kfilewidget

not mistaken. Thank you for looking into this. - Maarten --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120071/#review65867 ----------

Re: Review Request 119958: Fix thumbnails for mimetype groups.

rc/widgets/previewjob.cpp 55a3fb7 Diff: https://git.reviewboard.kde.org/r/119958/diff/ Testing --- I'm porting a thumbnailer to frameworks 5. Before nothing happend, now I see thumbnails. Thanks, Maarten De Meyer ___ Kde-frameworks-devel m

Re: Review Request 119958: Fix thumbnails for mimetype groups.

rameworks 5. Before nothing happend, now I see thumbnails. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

6c9fa thumbnail/imagecreator.cpp dd5ffe2 Diff: https://git.reviewboard.kde.org/r/120058/diff/ Testing --- Removed my thumbnail cache and created new thumbnails. Works both from dolphin and from plasma. Thanks, Maarten De Meyer ___ Kde-frameworks-

Re: Review Request 120071: QUrl::fromUserInput in kfilewidget

/kfilewidget.cpp 10c6120 Diff: https://git.reviewboard.kde.org/r/120071/diff/ Testing --- Now I can open absolute url's with KFileDialog Local and remote files work. Not tested: KDEPlatformFileDialog Thanks, Maarten De Meyer __

Review Request 120071: QUrl::fromUserInput in kfilewidget

--- Now I can open absolute url's with KFileDialog Local and remote files work. Not tested: KDEPlatformFileDialog Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinf

Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

https://git.reviewboard.kde.org/r/120058/diff/ Testing --- Removed my thumbnail cache and created new thumbnails. Works both from dolphin and from plasma. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 119958: Fix thumbnails for mimetype groups.

iff: https://git.reviewboard.kde.org/r/119958/diff/ Testing --- I'm porting a thumbnailer to frameworks 5. Before nothing happend, now I see thumbnails. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-deve

Review Request 120058: Move imagethumbnailer away from KDE4Support

sting --- Removed my thumbnail cache and created new thumbnails. Works both from dolphin and from plasma. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frame

Review Request 119958: Fix thumbnails for mimetype groups.

x27;m porting a thumbnailer to frameworks 5. Before nothing happend, now I see thumbnails. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119907: KIO: Correctly generate previews.

/normal/$md5.png Diffs - src/widgets/previewjob.cpp c65d683 Diff: https://git.reviewboard.kde.org/r/119907/diff/ Testing --- Open a folder with images in dolphin, check the location and name. Thanks, Maarten De Meyer ___ Kde

Re: Review Request 119907: KIO: Correctly generate previews.

On Aug. 22, 2014, 6:57 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119907/ >

Review Request 119907: KIO: Correctly generate previews.

://git.reviewboard.kde.org/r/119907/diff/ Testing --- Open a folder with images in dolphin, check the location and name. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119869: KIO: Correctly handle .directory files

ng this to KConfig and KIO? Diffs - src/widgets/kdesktopfileactions.cpp 9486015 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarte

Re: Review Request 119868: KConfig add DirectoryType support

tically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/#review64952 ----------- On Aug. 21, 2014, 1:15 p.m., Maarten De Meyer wrote: > > --- > This is an

Re: Review Request 119869: KIO: Correctly handle .directory files

rc/widgets/kdesktopfileactions.cpp 9486015 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarten De Meyer ___ Kde-frameworks-devel ma

Re: Review Request 119868: KConfig add DirectoryType support

2190051 src/core/kdesktopfile.cpp 6278309 Diff: https://git.reviewboard.kde.org/r/119868/diff/ Testing --- Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119869: KIO: Correctly handle .directory files

rc/widgets/kdesktopfileactions.cpp 9486015 src/widgets/kpropertiesdialog.cpp 346cbe8 Diff: https://git.reviewboard.kde.org/r/119869/diff/ Testing --- Configure a folder with a custom icon in dolphin. Click the created .directory file. Thanks, Maarte

Re: Review Request 119868: KConfig add DirectoryType support

Diff: https://git.reviewboard.kde.org/r/119868/diff/ Testing --- Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117974: Some more KArchive examples

ATION examples/bzip2gzip/main.cpp PRE-CREATION examples/unzipper/CMakeLists.txt PRE-CREATION examples/unzipper/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117974/diff/ Testing --- Builds and runs ok. Easy to read and comprehend. (imho) Thanks, Maarten De

Re: Review Request 117974: Some more KArchive examples

xamples/unzipper/main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117974/diff/ > > > Testing > --- > > Builds and runs ok. > Easy to read and comprehend. (imho) > > > Thanks, > > Maarten De Meyer > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117974: Some more KArchive examples

.kde.org/r/117974/diff/ Testing --- Builds and runs ok. Easy to read and comprehend. (imho) Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117974: Some more KArchive examples

ATION examples/unzipper/main.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/117974/diff/ Testing --- Builds and runs ok. Easy to read and comprehend. (imho) Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frame

Re: Review Request 114111: Fix KIconThemes standalone build

KGuiAddons and KIconThemes doesn't link with KGuiAddons directly. You say it "complains" so you are still able to build? Next version of CMake should fix this. - Maarten De Meyer On Nov. 25, 2013, 3:32 p.m., Bhu

Re: Review Request 113910: Add basic KArchive examples

mples/helloworld/main.cpp PRE-CREATION tier1/karchive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113910/diff/ Testing --- Builds and runs without errors. Thanks, Maarten De

Re: Review Request 113910: Add basic KArchive examples

------------- On Nov. 25, 2013, 2:46 p.m., Maarten De Meyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/113910/ > --

Re: Review Request 113910: Add basic KArchive examples

chive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113910/diff/ Testing --- Builds and runs without errors. Thanks, Maarten De Meyer __

Re: Review Request 113910: Add basic KArchive examples

chive/examples/tarlocalfiles/CMakeLists.txt PRE-CREATION tier1/karchive/examples/helloworld/main.cpp PRE-CREATION tier1/karchive/examples/helloworld/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113910/diff/ Testing --- Builds and runs without errors. Thanks, Maart

Review Request 113910: Add basic KArchive examples

ATION tier1/karchive/examples/tarlocalfiles/main.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113910/diff/ Testing --- Builds and runs without errors. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-

Re: Review Request 113683: Fix kdeclarative standalone build

56e17dd42a8cc2b2c8a0015c7c5ec74902e0bd3e tier3/kdeclarative/CMakeLists.txt 1f23914a0ba65982c7b597e92fe9c9e920e2abe6 Diff: http://git.reviewboard.kde.org/r/113683/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list

Review Request 113683: Fix kdeclarative standalone build

1f23914a0ba65982c7b597e92fe9c9e920e2abe6 Diff: http://git.reviewboard.kde.org/r/113683/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113818/#review43524 --- Ship it! Ship It! - Maarten De Meyer On Nov. 12, 2013, 3

Re: Review Request 113708: Make kcmutils build standalone

http://git.reviewboard.kde.org/r/113708/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113731: Fix kdesu standalone build.

superbuild/CMakeLists.txt 80de8667b338c91922f627eaf92073a9a51645d8 Diff: http://git.reviewboard.kde.org/r/113731/diff/ Testing --- builds :) Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 113730: Fix kpty standalone build

s.txt f78e3fe105aae313dcb5eeb7524c12a8e8533bf0 Diff: http://git.reviewboard.kde.org/r/113730/diff/ Testing --- Builds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113731: Fix kdesu standalone build.

://git.reviewboard.kde.org/r/113731/diff/ Testing --- builds :) Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113730: Fix kpty standalone build

uilds. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113703: Fix KRoss standalone build

--- Builds. Not added to superbuild. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113702: Fix KEmoticons standalone build

/src/core/CMakeLists.txt 556d9bb Diff: http://git.reviewboard.kde.org/r/113702/diff/ Testing --- Builds. KCoreAddons is pulled in by KService Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 113708: Make kcmutils build standalone

--- Make kcmutils build standalone. I'll add it to superbuild when commiting. Diffs - tier4/kcmutils/CMakeLists.txt ef65009 tier4/kcmutils/src/CMakeLists.txt daeb662 Diff: http://git.reviewboard.kde.org/r/113708/diff/ Testing --- Builds. Thanks, Maarten De

Re: Review Request 113702: Fix KEmoticons standalone build

an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113702/#review43216 ----------- On Nov. 7, 2013, 10:47 a.m., Maarten De Meyer wrote: > > --- > T

Re: Review Request 113703: Fix KRoss standalone build

ith a fresh build they are no longer needed. Thanks. - Maarten --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113703/#review43213 ------------

Re: Review Request 113703: Fix KRoss standalone build

--- Builds. Not added to superbuild. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113703: Fix KRoss standalone build

superbuild. Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113702: Fix KEmoticons standalone build

/ Testing --- Builds. KCoreAddons is pulled in by KService Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113684: Make KunitConversion build standalone

builds Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113684: Make KunitConversion build standalone

/ Testing --- Framework builds Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113684: Make KunitConversion build standalone

--- Framework builds Thanks, Maarten De Meyer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel